test(logging): allow for overriding and enabling logging of caller field #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8726458791Details
💛 - Coveralls |
…gingOfCallerField
tallaxes
approved these changes
Apr 11, 2024
| @@ -191,6 +191,9 @@ az-run-sample: ## Deploy sample Provisioner and workload (with 0 replicas, to be | |||
| kubectl apply -f examples/v1beta1/general-purpose.yaml | |||
| kubectl apply -f examples/workloads/inflate.yaml | |||
|
|
|||
| az-enable-logging-caller: ## Enable logging the caller field (file path, name, and line number) | |||
| yq -i '.manifests.helm.releases[0].overrides.logConfig ."disableCaller" = false' skaffold.yaml | |||
There was a problem hiding this comment.
Suggested change
| yq -i '.manifests.helm.releases[0].overrides.logConfig ."disableCaller" = false' skaffold.yaml | |
| yq -i '.manifests.helm.releases[0].overrides.logConfig.disableCaller = false' skaffold.yaml |
(not a blocker)
SG, yea happy to delay |
tallaxes
added
the
size/XS
…gingOfCallerField
…dingAndEnablingLoggingOfCallerField
There was a problem hiding this comment.
All logging improvements are best deferred until we this gets in kubernetes-sigs/karpenter#1050
|
@charliedmcb please see if this needs to be revisited |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
Description
Allow for overriding and enabling the caller field which contains file path, name, and line number of the log. Also, adds a make command to enable it.
How was this change tested?
created a standalone setup in codespaces, and tested both with, and without
az-enable-logging-callerto ensure thecallerfield shows up correctly.*
Does this change impact docs?
Release Note