Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove confidential VM SKUs (DC,EC) from consideration #23

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Nov 10, 2023

Fixes #

Description

This removes confidential VM SKUs (DC,EC) from consideration, since the current provider does not support them (yet). The implementation looks for DC or EC prefix in the VM Size name, as apparently there is no direct confidential capability indication available in SKU resource API. Not filtering all *C, because NCs are supported GPU SKUs.

The above is the only functional change, the rest is refactoring and test.
Some of the refactoring was needed to consolidate all filtering in one place, and without triggering gocyclo.
Consolidated filter also fixes the post-filter count of SKUs reported in the log. Expect it to be lower (and not just because confidential VMs are now filtered out).

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Copy link
Collaborator Author

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@tallaxes tallaxes merged commit 61d82d3 into main Nov 14, 2023
5 checks passed
@tallaxes tallaxes deleted the tallaxes/confidential branch November 14, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants