Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): fix checkout in e2e test workflow to test the PR's branch #22

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

charliedmcb
Copy link
Collaborator

@charliedmcb charliedmcb commented Nov 10, 2023

Fixes #

Description
Noticed in some of my testing that the E2E workflows were no longer pointing at the PR test branch, and instead pointing at main.

See this PR:
#21
with a panic in the drift test suite:
image
Passing the drift test:
image

 This PR is changing the workflows to ensure they are checking out the intended branch for testing.
 
How was this change tested?
None. Needs to be checked into main
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@charliedmcb charliedmcb marked this pull request as ready for review November 10, 2023 01:10
@charliedmcb charliedmcb changed the title test(e2e): fix checkout in e2e test workflow to test the branch test(e2e): fix checkout in e2e test workflow to test the PR's branch Nov 10, 2023
@charliedmcb charliedmcb merged commit ddc9e77 into main Nov 10, 2023
6 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/fixE2ETestsRunningOnBranch branch November 10, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants