test(e2e): change to have the ApprovalComment only trigger e2e suite on success #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallaxes
previously approved these changes
Nov 8, 2023
tallaxes
approved these changes
Nov 8, 2023
charliedmcb
deleted the
charliedmcb/makeApprovalTriggerOnlyTriggerE2EOnSuccess
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Currently the ApprovalComment workflow will trigger the e2e suite even on a skipped status. We only want the workflow to be triggered on a successful run status. This PR is meant to fix it.
How was this change tested?
Sadly workflow changes need to be committed into the mainline to get executed. Will test immediately afterwards.
*
Does this change impact docs?
Release Note