[draft]Start controller #221
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
force-pushed
the
start-controller
branch
from
2ee0ff3
to
37a1e18
Compare
jwtty
reviewed
Nov 22, 2024
| userAssignedIdentityID: "7099e851-09b2-4214-ba5f-d4d7de33b8a3" | ||
| resourceGroup: "zhiyinglin-fleet-networking-e2e-atm-1" | ||
| location: "westcentralus" | ||
| vnetName: "my-vnet" |
There was a problem hiding this comment.
Since fleet version has been updated, we do not need this vnetName anymore.
| "userAssignedIdentityID": "7099e851-09b2-4214-ba5f-d4d7de33b8a3", | ||
| "resourceGroup": "zhiyinglin-fleet-networking-e2e-atm-1", | ||
| "location": "westcentralus", | ||
| "vnetName": "my-vnet", |
| cloud: "AzurePublicCloud" | ||
| subscriptionId: "c4528d9e-c99a-48bb-b12d-fde2176a43b8" | ||
| useManagedIdentityExtension: true | ||
| userAssignedIdentityID: "7099e851-09b2-4214-ba5f-d4d7de33b8a3" |
There was a problem hiding this comment.
let's not leave the clientID in PR.
| "cloud": "AzurePublicCloud", | ||
| "subscriptionId": "c4528d9e-c99a-48bb-b12d-fde2176a43b8", | ||
| "useManagedIdentityExtension": true, | ||
| "userAssignedIdentityID": "7099e851-09b2-4214-ba5f-d4d7de33b8a3", |
| --vnet-subnet-id "/subscriptions/$AZURE_SUBSCRIPTION_ID/resourceGroups/$RESOURCE_GROUP/providers/Microsoft.Network/virtualNetworks/$VNET/subnets/$MEMBER_2_SUBNET" \ | ||
| --enable-managed-identity --assign-identity ${MEMBER_CLUSTER_2_AKS_IDENTITY_ID} --assign-kubelet-identity ${MEMBER_CLUSTER_2_AKS_KUBELET_IDENTITY_ID} \ | ||
| --no-wait | ||
| fi |
| userAssignedIdentityID: "${HUB_CLUSTER_KUBELET_CLIENT_ID}" | ||
| resourceGroup: "${RESOURCE_GROUP}" | ||
| location: "${LOCATION}" | ||
| vnetName: "my-vnet" |
There was a problem hiding this comment.
We do not need this anynore.
| userAssignedIdentityID: "${MEMBER_CLUSTER_1_KUBELET_CLIENT_ID}" | ||
| resourceGroup: "${AKS_MEMBER_1_NODE_RESOURCE_GROUP}" | ||
| location: "${LOCATION}" | ||
| vnetName: "my-vnet" |
| subscriptionId: "${AZURE_SUBSCRIPTION_ID}" | ||
| useManagedIdentityExtension: true | ||
| userAssignedIdentityID: "${HUB_CLUSTER_KUBELET_CLIENT_ID}" | ||
| resourceGroup: "${RESOURCE_GROUP}" |
There was a problem hiding this comment.
So then in the script, we will create the ATM in the aks resource group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer