Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kubebuilders validations for name length to be <= 63 #218

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jamyct
Copy link

@jamyct jamyct commented Nov 15, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@jamyct jamyct changed the title add kubebuilders validations for name length to be <= 63 feat: add kubebuilders validations for name length to be <= 63 Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.65%. Comparing base (aef3b54) to head (a87267d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   79.68%   79.65%   -0.03%     
==========================================
  Files          27       27              
  Lines        3819     3819              
==========================================
- Hits         3043     3042       -1     
- Misses        620      621       +1     
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jamyct jamyct added the enhancement New feature or request label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant