Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Add events #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add events #354

wants to merge 1 commit into from

Conversation

ap-git-hub
Copy link
Contributor

@ap-git-hub ap-git-hub commented Apr 17, 2019 •
edited by dluc
Loading

Description and Motivation

Added events for start, stop, restart simulation.

Change type

  • Bug fix
  • New feature
  • Enhancement
  • Breaking change (breaks backward compatibility)

Checklist:

  • All tests passed
  • The code follows the code style and conventions of this project
  • The change requires a change to the documentation
  • I have updated the documentation accordingly

This change is Reviewable

sarthakvijayvergiya
sarthakvijayvergiya suggested changes Jan 2, 2021
View reviewed changes
Services/Simulations.cs
@@ -309,6 +310,15 @@ public async Task<Models.Simulation> UpsertAsync(Models.Simulation simulation, b
if (simulationIsRestarting)
{
simulation = await this.ResetSimulationStatisticsAsync(simulation);

simulation = await this.ResetSimulationStatisticsAsync(simulation);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate statement!!

Suggested change
simulation = await this.ResetSimulationStatisticsAsync(simulation);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarthakvijayvergiya sarthakvijayvergiya sarthakvijayvergiya requested changes

@peterfelts peterfelts Awaiting requested review from peterfelts

@saixiaohui saixiaohui Awaiting requested review from saixiaohui

@pratik11jain pratik11jain Awaiting requested review from pratik11jain

@tommo-ms tommo-ms Awaiting requested review from tommo-ms

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ap-git-hub @sarthakvijayvergiya @avani-kp