Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Storage Templates #118

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updated Storage Templates #118

wants to merge 4 commits into from

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Feb 2, 2022 •
edited
Loading

Summary of the Pull Request

  • Deny public access
  • ZRS/LRS updates
  • Deny cross-tenant replication
  • Default to OAuth
  • Enable Soft Delete
  • Allow Microsoft trusted services as it is required for No public IP clusters and CIs

References

No references

PR Checklist

Validation Steps Performed

See checks below.

@marvinbuss marvinbuss added feature Feature Requests committed Committed item labels Feb 2, 2022
@marvinbuss marvinbuss added this to the v1.3.0 milestone Feb 2, 2022
@marvinbuss marvinbuss self-assigned this Feb 2, 2022
@marvinbuss marvinbuss requested a review from a team as a code owner February 2, 2022 16:05
marvinbuss
marvinbuss commented Feb 2, 2022
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanjeetsingh amanjeetsingh amanjeetsingh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@marvinbuss marvinbuss

Labels
committed Committed item feature Feature Requests
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinbuss @amanjeetsingh