Add subscription information when to call builder #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert docker action to typescript * Add step to delete container app env back * Remove workflow_dispatch * Remove commented out code * Fix formating * Update image name * Address PR comments * Remove reference to Command Helper * Address PR comments * Remove commented code * ci: add Azure Static Web Apps workflow file on-behalf-of: @Azure [email protected] * Delete .github/workflows/azure-static-web-apps-ashy-ocean-015179e0f.yml * Update Azure CLI extensions installation * Await setupAzureCli * Refactor and trigger pipeline * Refactor TelemetryHelper * Reformat and remove new line * Refactor and re-trigger pipeline * Address PR comments * Address PR comments * Change comment for build-specific properties * Refactor default containerapp name * Change command construction * Change command signature * Fix command to get runtime stack * Fix oryx dockerfile command to get runtime stack * Fix oryx dockerfile command to get runtime stack * Fix command to set default builder * Test containerapp creation * Hard code location and re-trigger pipeline * Re-trigger pipeline and test * Fix docker push command * Address PR comments * Fix formating for oryx dockerfile command * Add double quotes * Address PR comments * Change executeAndThrowIfError to execute * Support registry arguments * Updated index.js * Fix docker login command * Re-order container registry authentication * Add space
* Migrate latest changes from v1 to v2 * Support build arguments for Dockerfile and builder scenario * Fix typo in docs
* Initial commit to support private registry scenario * Add global var to delegate build to CLI * Update condition to use CLI * Fix formatting * Update validation for internal registry scenario * Address PR comments * Update condition to use internal registry * Test validation for internal registry scenario * Get value of imageToBuild before build * Fetch imageToBuild arg and test * Move code to fetch imageToBuild in validation * Install extension * Trigger pipeline * Re-trigger pipeline to install extensions * Re-trigger pipeline to isntall extension * Install extension and re-trigger pipeline * Explicitly install extension * Trigger pipeline * Re-trigger pipeline * Change whl name * Fix pipeline failure and re-trigger * Fix pipeline failures * Install extension explicitly * Fix valiation failures * Fix validation failures * Test validation failures * Test validation failures * Remove location * Test validation pipeline * Test validation pipeline * Test validation pipeline * Test validation pipeline * Test validation pipeline * Trigger validation pipeline * Test validation pipeline * Address validation failures * Address PR discussion comments * Made `imageToDeploy` optional * Remove step to install whl * Address PR comments * Addressed PR comments * Fix typo * Remove space * Fix merge failure * Remove --debug * Test registry scenario * Fix merge failures and re-trigger pipeline * Add --debug * Create containerapp with up * Create container app with up * Trigger validation pipeline * Test container app creation with up * Add location to up command * Use up for just private registry scenario * Change rg for update scenario * Remove step to delete pushed image * Test containerapp update with up * Hardcode location to northcentralusstage * Remove app source path --------- Co-authored-by: Cormac McCarthy <[email protected]>
* Remove env as a required arg * Add index.js * Address PR comments * Remove env param
Update targeted builders to 20231107.2
* Snap to containerapp version 0.3.43 * Modify update command * Comment out imageToDeploy * Add --debug to the update command * Comment out `--source` * Enable build and push from ghs * Build and push from gha * Ensuer -i and --source are not used together * Fix typo * Revert comment * Add global var to determine cloud build scenario
* Remove location * Change logic to set location * Check if env is provided * Fix logic to set location * Update logic to set location * Add comments * Remove space * Remove location param * Remove location * Refactor * Reorder arguments * Address PR comments * Fix typo * Fix typo * Fix PR comments * Address PR comments * Revert change to set this.containerrAppExists * Refactor * Add comment * Change validation pipeline name
This reverts commit 6cecedf.
and 'ingress update' commands
This reverts commit 6cecedf.
Fixing ACR credential issues when up command was used
support build environment variable
…-action into corm/zhiyongli/telforsub # Conflicts: # dist/index.js # src/ContainerAppHelper.ts
daniv-msft
reviewed
Jan 11, 2024
added 2 commits
January 24, 2024 21:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from #86