Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide output from 'az containerapp' commands #65

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

cormacpayne
Copy link
Member

@cormacpayne cormacpayne commented Oct 10, 2023

This PR addresses the following:

  • Removes the output produced from az containerapp create/update/up
  • Displays the Container App's FQDN at the end of the action (displayed no matter what by az containerapp commands)

daniv-msft
daniv-msft previously approved these changes Oct 10, 2023
@cormacpayne cormacpayne force-pushed the corm/update-aca-cli-output branch from 45eb493 to a7e3cef Compare October 10, 2023 22:09
@cormacpayne cormacpayne changed the title Hide output from 'az containerapp' commands, show FQDN at end of action Hide output from 'az containerapp' commands Oct 10, 2023
@cormacpayne cormacpayne merged commit ccd0cf4 into main Oct 11, 2023
13 checks passed
@cormacpayne cormacpayne deleted the corm/update-aca-cli-output branch October 11, 2023 00:00
@bcspragu
Copy link

Hello! I think this PR breaks some deploys. There seems to be a line --output that should be --output none:

https://github.com/Azure/container-apps-deploy-action/blame/ccd0cf4128b53751252c85270a8922e5c04a0c78/action.yml#L347

Example error: https://github.com/RMI-PACTA/app/actions/runs/6476788688/job/17586033990

Run az containerapp show \
  az containerapp show \
    -g rmi-pacta-dev \
    -n pactasrv-dev \
    --output && CA_GH_ACTION_RESOURCE_EXISTS=true || CA_GH_ACTION_RESOURCE_EXISTS=false
  echo "CA_GH_ACTION_RESOURCE_EXISTS=${CA_GH_ACTION_RESOURCE_EXISTS}" >> $GITHUB_ENV
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    AZURE_HTTP_USER_AGENT: 
    AZUREPS_HOST_ENVIRONMENT: 
    CA_GH_ACTION_IMAGE_TO_DEPLOY: rmipacta.azurecr.io/pacta:dev
    CA_GH_ACTION_RESOURCE_GROUP: rmi-pacta-dev
    CA_GH_ACTION_CONTAINER_APP_LOCATION_ARG: --location centalus
  
ERROR: argument --output/-o: expected one argument

@daniv-msft
Copy link
Contributor

Thank you very much @bcspragu ! We're looking into this and will get back to you

@daniv-msft
Copy link
Contributor

@bcspragu We've merged the PR fixing this: #66
We'll release it in a few minutes. Thanks again and sorry for the issue.

@bcspragu
Copy link

No worries @daniv-msft, and thanks for the quick turnaround!

@daniv-msft
Copy link
Contributor

Thanks! I confirm the change was released. Kudos to @cormacpayne

@cormacpayne
Copy link
Member Author

Thank you for the catch @bcspragu :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants