Convert composite action to typescript #61
Conversation
snehapar9
changed the title
…tps://github.com/Azure/container-apps-deploy-action into snehapar/container-apps-deploy-action-javascript
|
I was SURE I made this comment on the PR a couple of weeks back, and I cannot find it so I must have dreamt/forgot to publish it: is it right to assume that most of the code changes are exactly the same as the ADO Task, and that as such we should focus the review on what has changed? If yes, could you please point out the files that are new additions? |
From here all the files under src should be the same with some expections The dist folder is a new addition but was created by compiling azurecontainerapps.ts and does not need to be reviewed. |
Thanks @snehapar9! I'm reviewing specifically |
| } | ||
|
|
||
| public getDefaultContainerAppName(containerAppName: string): string { | ||
| containerAppName = `gh-action-app-${this.getBuildId()}-${this.getBuildNumber()}`; |
There was a problem hiding this comment.
Nit: do we need both the buildId and buildNumber?
azurecontainerapps.ts
Outdated
| // If a Container Registry URL was provided, try to authenticate against it | ||
| if (!this.util.isNullOrEmpty(this.registryUrl)) { | ||
| await this.authenticateContainerRegistryAsync(); | ||
| } |
There was a problem hiding this comment.
Let's move this block before the acrName check block above because authenticateAzureContainerRegistryAsync is going to set the value of registryUrl to include the value of acrName, so both of these if-statements will be hit
snehapar9
deleted the
snehapar/container-apps-deploy-action-javascript
branch
* Convert composite action to typescript (#61) * Convert docker action to typescript * Add step to delete container app env back * Remove workflow_dispatch * Remove commented out code * Fix formating * Update image name * Address PR comments * Remove reference to Command Helper * Address PR comments * Remove commented code * ci: add Azure Static Web Apps workflow file on-behalf-of: @Azure [email protected] * Delete .github/workflows/azure-static-web-apps-ashy-ocean-015179e0f.yml * Update Azure CLI extensions installation * Await setupAzureCli * Refactor and trigger pipeline * Refactor TelemetryHelper * Reformat and remove new line * Refactor and re-trigger pipeline * Address PR comments * Address PR comments * Change comment for build-specific properties * Refactor default containerapp name * Change command construction * Change command signature * Fix command to get runtime stack * Fix oryx dockerfile command to get runtime stack * Fix oryx dockerfile command to get runtime stack * Fix command to set default builder * Test containerapp creation * Hard code location and re-trigger pipeline * Re-trigger pipeline and test * Fix docker push command * Address PR comments * Fix formating for oryx dockerfile command * Add double quotes * Address PR comments * Change executeAndThrowIfError to execute * Support registry arguments * Updated index.js * Fix docker login command * Re-order container registry authentication * Add space * Migrate latest changes from v1 to v2 (#68) * Migrate latest changes from v1 to v2 * Support build arguments for Dockerfile and builder scenario * Fix typo in docs * Support private registry scenario (#69) * Initial commit to support private registry scenario * Add global var to delegate build to CLI * Update condition to use CLI * Fix formatting * Update validation for internal registry scenario * Address PR comments * Update condition to use internal registry * Test validation for internal registry scenario * Get value of imageToBuild before build * Fetch imageToBuild arg and test * Move code to fetch imageToBuild in validation * Install extension * Trigger pipeline * Re-trigger pipeline to install extensions * Re-trigger pipeline to isntall extension * Install extension and re-trigger pipeline * Explicitly install extension * Trigger pipeline * Re-trigger pipeline * Change whl name * Fix pipeline failure and re-trigger * Fix pipeline failures * Install extension explicitly * Fix valiation failures * Fix validation failures * Test validation failures * Test validation failures * Remove location * Test validation pipeline * Test validation pipeline * Test validation pipeline * Test validation pipeline * Test validation pipeline * Trigger validation pipeline * Test validation pipeline * Address validation failures * Address PR discussion comments * Made `imageToDeploy` optional * Remove step to install whl * Address PR comments * Addressed PR comments * Fix typo * Remove space * Fix merge failure * Remove --debug * Test registry scenario * Fix merge failures and re-trigger pipeline * Add --debug * Create containerapp with up * Create container app with up * Trigger validation pipeline * Test container app creation with up * Add location to up command * Use up for just private registry scenario * Change rg for update scenario * Remove step to delete pushed image * Test containerapp update with up * Hardcode location to northcentralusstage * Remove app source path --------- Co-authored-by: Cormac McCarthy <[email protected]> * Remove env as a required arg (#72) * Remove env as a required arg * Add index.js * Address PR comments * Remove env param * Update targeted builders to 20231107.2 * Build and push non cloud scenarios from GHA (#75) * Snap to containerapp version 0.3.43 * Modify update command * Comment out imageToDeploy * Add --debug to the update command * Comment out `--source` * Enable build and push from ghs * Build and push from gha * Ensuer -i and --source are not used together * Fix typo * Revert comment * Add global var to determine cloud build scenario * Remove location (#76) * Remove location * Change logic to set location * Check if env is provided * Fix logic to set location * Update logic to set location * Add comments * Remove space * Remove location param * Remove location * Refactor * Reorder arguments * Address PR comments * Fix typo * Fix typo * Fix PR comments * Address PR comments * Revert change to set this.containerrAppExists * Refactor * Add comment * Change validation pipeline name * support build environment variable * fix comiple error * build ts file * package ts file * Revert "fix comiple error" This reverts commit 6cecedf. * fix validation error * Update Container App with 'containerapp update' and 'ingress update' commands * support quotation mark * fix validation * add log * build typescript to js * Revert "fix comiple error" This reverts commit 6cecedf. * package ts to js * define constant for regex * build ts to js * Update Container App and Ingress separately * Addressed comment and kept support for admin cred * Fixed typo in validation * support docker file build for buildArguments * Update Azure login secrets for OIDC testing * refine readme format * add validation for build environment variable * refine env name validation logic * Fixed typo and updated timeout on validation task * Fixed mismatch resource group name in validation * regenerate index.js * fix merge mistake * add examples for arg buildArguments * add usage for buildArguments * not validate build argument name when there's Dockerfile in root path --------- Co-authored-by: snehapar9 <[email protected]> Co-authored-by: Dan Vouaux <[email protected]> Co-authored-by: daniv-msft <[email protected]> Co-authored-by: yilims <[email protected]> Co-authored-by: harrli <[email protected]> Co-authored-by: Harry Li <[email protected]> Co-authored-by: Yi Li <[email protected]>
This change converts the existing composite action to a typescript based action so we can incorporate the private registry scenario.