Live announcement update when a message is received/edited from/by other users #5540
Conversation
…essage-announcement-update
vhuseinova-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gtcoaizgql.chromatic.com/ |
| @@ -205,8 +205,12 @@ const extractContentForAllyMessage = (props: ChatMessageContentProps): string => | |||
| }; | |||
|
|
|||
| const generateLiveMessage = (props: ChatMessageContentProps): string => { | |||
| const liveAuthor = _formatString(props.strings.liveAuthorIntro, { author: `${props.message.senderDisplayName}` }); | |||
|
|
|||
| const liveAuthorIntro = props.message.editedOn | |||
There was a problem hiding this comment.
Why do we toLowerCase on only one of these paths?
There was a problem hiding this comment.
Edited string is added for edited message announcement. See the functionality in:
return `${props.message.editedOn ? props.strings.editedTag : ''} ${
props.message.mine ? '' : liveAuthor
} ${extractContentForAllyMessage(props)} `;
There was a problem hiding this comment.
I'm curious then if this is the right place to lowercase it? We're doing that to make it fit with English word position, correct? Does this apply across all languages?
There was a problem hiding this comment.
Will check o nthe strings with the accessibility team and update the PR
@azure/communication-react jest test coverage for beta.
|
@azure/communication-react jest test coverage for stable.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Chat bundle size is increased❗.
|
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xcpbrudoxz.chromatic.com/ |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
What
Why
How Tested
Process & policy checklist
Is this a breaking change?