together mode component #5517
together mode component #5517
Conversation
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-crsepazbre.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
cn0151
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-swjbpdkbrv.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rqqrajzgjk.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-niicbykrep.chromatic.com/ |
packages/react-components/src/components/TogetherModeOverlay.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/TogetherModeOverlay.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/TogetherModeOverlay.tsx
Outdated
Show resolved
Hide resolved
| parentWidth | ||
| ]); | ||
|
|
||
| return screenShareComponent ? ( |
There was a problem hiding this comment.
To cut down on duplicated code maybe the thing to do here when screenshare is active is to have the VideoGallery use another layout. at lease until we are wanting to support a different view for together mode?
There was a problem hiding this comment.
I can address this in my next PR where I am looking into this.
packages/react-components/src/components/VideoGallery/TogetherModeStream.tsx
Outdated
Show resolved
Hide resolved
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fionwcmyla.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-tixldgglvf.chromatic.com/ |
…Azure/communication-ui-library into cnwankwo/togethermode-component
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bzrxcxoouk.chromatic.com/ |
| }) => { | ||
| const locale = useLocale(); | ||
| const theme = useTheme(); | ||
| const callingPalette = (theme as unknown as CallingTheme).callingPalette; |
There was a problem hiding this comment.
We shouldn't need to cast this as unknown, this is similar to saying the type is any. lets make sure that this is defined as a CallingTheme where expected.
There was a problem hiding this comment.
good catch, yup we shouldn't have to do this.
There was a problem hiding this comment.
Actually we need to. Theme interface from fluent ui does not overlap with CallingTheme
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zdjizhgybo.chromatic.com/ |
CallWithChat bundle size is not changed.
|
Chat bundle size is not changed.
|
Calling bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-oqnmyapeyn.chromatic.com/ |
What
This PR contains together mode component layout and styling
Why
Needed as part of together mode implementation
How Tested
locally
Process & policy checklist
Is this a breaking change?