Skip to content

Commit

Permalink
Merge branch 'fuyan/hard-mute-sdk-reference' of https://github.com/Az…
Browse files Browse the repository at this point in the history
…ure/communication-ui-library into fuyan/hard-mute-sdk-reference
  • Loading branch information
fuyan2024 committed Jan 13, 2025
2 parents 2cea1c1 + c3d3256 commit fa1823f
Show file tree
Hide file tree
Showing 31 changed files with 1,054 additions and 61 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ jobs:
# Pull requests show details of coverage changes
- name: Get jest tests coverage of main from gist
if: ${{ github.event_name == 'pull_request' && !startsWith(github.event.pull_request.base.ref, 'release/') }}
run: curl -o temp/jest/base/coverage-report.json "https://gist.github.com/communication-ui-bot/${{ matrix.coverage_gist_id }}/raw/communication-react-jest-report-${{ matrix.flavor }}.json" --create-dirs -L
run: curl -o temp/jest/base/coverage-report.json "https://gist.github.com/alkwa-msft/${{ matrix.coverage_gist_id }}/raw/communication-react-jest-report-${{ matrix.flavor }}.json" --create-dirs -L
- name: Calculate coverage change
if: ${{ github.event_name == 'pull_request' && !startsWith(github.event.pull_request.base.ref, 'release/') }}
id: coverage
Expand Down Expand Up @@ -787,11 +787,11 @@ jobs:
include:
# These are gist to track bundle sizes
- app: Chat
gist: https://gist.github.com/communication-ui-bot/db13fa7067b083b7a91d7a95adf28be1
gist: https://gist.github.com/alkwa-msft/f19649d941b2739b13402ee4802aa851
- app: Calling
gist: https://gist.github.com/communication-ui-bot/87d57b63bbbaee12273a9a901b67885c
gist: https://gist.github.com/alkwa-msft/8160c0362cb05b7b09f3dbf803007c73
- app: CallWithChat
gist: https://gist.github.com/communication-ui-bot/72a7fca0af8a3c5b37f966bb6d4bcd11
gist: https://gist.github.com/alkwa-msft/c43393ae31b5b08215f3f49ed327d912
steps:
# checkout base bundle stats
- name: Get bundle stats of main from gist
Expand Down Expand Up @@ -867,11 +867,11 @@ jobs:
include:
# These are gist to track bundle sizes
- app: Chat
gist_id: db13fa7067b083b7a91d7a95adf28be1
gist_id: f19649d941b2739b13402ee4802aa851
- app: Calling
gist_id: 87d57b63bbbaee12273a9a901b67885c
gist_id: 8160c0362cb05b7b09f3dbf803007c73
- app: CallWithChat
gist_id: 72a7fca0af8a3c5b37f966bb6d4bcd11
gist_id: c43393ae31b5b08215f3f49ed327d912
steps:
- uses: actions/download-artifact@v4
with:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "minor",
"area": "feature",
"workstream": "Hard mute",
"comment": "We are excited to announce that the Azure Communication Services Web UI Library now supports the Media Access feature. This feature allows organizers, co-organizers, and presenters to control the ability of other attendees to send audio and video while in a call. Attendees can determine if their audio or video is enabled or disabled and check the media access status of other participants. Developers can integrate this functionality through our composites (e.g., CallComposite, CallWithChatComposite) as well as through components.",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "prerelease",
"area": "feature",
"workstream": "together-mode",
"comment": "together mode component",
"packageName": "@azure/communication-react",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "prerelease",
"area": "improvement",
"workstream": "Repairing Bundle Size Gist download/upload for CI",
"comment": "temporary change to get bundle size updates to work again",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "minor",
"area": "feature",
"workstream": "Hard mute",
"comment": "We are excited to announce that the Azure Communication Services Web UI Library now supports the Media Access feature. This feature allows organizers, co-organizers, and presenters to control the ability of other attendees to send audio and video while in a call. Attendees can determine if their audio or video is enabled or disabled and check the media access status of other participants. Developers can integrate this functionality through our composites (e.g., CallComposite, CallWithChatComposite) as well as through components.",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "none",
"area": "improvement",
"workstream": "[Test Coverage] Adding additional unit tests for _isValidIdentifier and _toCommunicationIdentifier",
"comment": "Added on several unit tests to the acs-ui-common packlet",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "none"
}
2 changes: 1 addition & 1 deletion common/config/babel/features.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ module.exports = {
// Demo feature. Used in live-documentation of conditional compilation.
// Do not use in production code.
"stabilizedDemo",
// Feature for forbid/permit remote participants audio/video access
// Feature for forbid/permit Teams meeting/group call attendee' audio/video access
"media-access"
]
}
4 changes: 2 additions & 2 deletions common/config/rush/variants/stable/common-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
*/
// "some-library": "1.2.3"
// This is the version for stable build (please also update allowedAlternativeVersions below)
"@azure/communication-calling": "^1.31.2",
"@azure/communication-calling": "^1.32.1",
"@azure/communication-common": "2.3.0",
"@azure/communication-chat": "^1.5.4",
"@azure/communication-signaling": "1.0.0-beta.29",
Expand Down Expand Up @@ -58,7 +58,7 @@
*/
"allowedAlternativeVersions": {
// This is the version for stable build (please also update preferredVersions above)
"@azure/communication-calling": ["^1.31.2"],
"@azure/communication-calling": ["^1.32.1"],
"@azure/communication-common": ["2.3.0"],
"@azure/communication-chat": ["^1.5.4"],
"@azure/communication-signaling": ["1.0.0-beta.29"],
Expand Down
52 changes: 26 additions & 26 deletions common/config/rush/variants/stable/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions common/config/workflows/matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
"include": [
{
"flavor": "stable",
"coverage_gist_id": "d1528e50153e6f7ea569040d7b437abb"
"coverage_gist_id": "19b238d46a84c28e44d689f0a8b57202"
},
{
"flavor": "beta",
"coverage_gist_id": "67224b1799c92f0e1cd2da24798e4dd5"
"coverage_gist_id": "aadc866e05b5243846b1c15a79ec1779"
}

]
Expand Down
38 changes: 37 additions & 1 deletion packages/acs-ui-common/src/identifier.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ import {
isPhoneNumberIdentifier,
isUnknownIdentifier
} from '@azure/communication-common';
import { fromFlatCommunicationIdentifier, toFlatCommunicationIdentifier } from './identifier';
import {
fromFlatCommunicationIdentifier,
toFlatCommunicationIdentifier,
_toCommunicationIdentifier,
_isValidIdentifier
} from './identifier';

test('Communication user conversions', () => {
const parsed = fromFlatCommunicationIdentifier('8:acs:OPAQUE');
Expand Down Expand Up @@ -94,3 +99,34 @@ test('Unknown user conversions', () => {
});
expect(toFlatCommunicationIdentifier(parsed)).toEqual('OPAQUE');
});

test('toCommunicationIdentifier with communication identifier', () => {
const userId = { kind: 'communicationUser', communicationUserId: '8:acs:OPAQUE' };
const identifierResponse = _toCommunicationIdentifier(userId);
expect(userId).toEqual(identifierResponse);
expect(identifierResponse).toEqual({
kind: 'communicationUser',
communicationUserId: '8:acs:OPAQUE'
});
});

test('toCommunicationIdentifier with communication identifier as string', () => {
const identifierResponse = _toCommunicationIdentifier('8:acs:OPAQUE');
expect(isCommunicationUserIdentifier(identifierResponse)).toBeTruthy();
expect(identifierResponse).toEqual({
kind: 'communicationUser',
communicationUserId: '8:acs:OPAQUE'
});
});

test('isValidIdentifier with communication identifier', () => {
const userId = { kind: 'communicationUser', communicationUserId: '8:acs:OPAQUE' };
const isValid = _isValidIdentifier(userId);
expect(isValid).toBeTruthy();
});

test('isValidIdentifier with unknown identifier', () => {
const userId = { kind: 'unknown', id: 'OPAQUE' };
const isValid = _isValidIdentifier(userId);
expect(isValid).toBeTruthy();
});
4 changes: 2 additions & 2 deletions packages/calling-component-bindings/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@
"reselect": "^4.0.0"
},
"peerDependencies": {
"@azure/communication-calling": "1.32.2-beta.1 || ^1.31.2",
"@azure/communication-calling": "1.32.2-beta.1 || ^1.32.1",
"@azure/communication-calling-effects": "^1.1.2",
"@types/react": ">=16.8.0 <19.0.0",
"react": ">=16.8.0 <19.0.0"
},
"devDependencies": {
"@azure/communication-calling": "1.32.2-beta.1 || ^1.31.2",
"@azure/communication-calling": "1.32.2-beta.1 || ^1.32.1",
"@azure/communication-calling-effects": "^1.1.2",
"@babel/cli": "^7.24.8",
"@babel/core": "^7.25.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/calling-stateful-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@
"immer": "10.1.1"
},
"peerDependencies": {
"@azure/communication-calling": "1.32.2-beta.1 || ^1.31.2"
"@azure/communication-calling": "1.32.2-beta.1 || ^1.32.1"
},
"devDependencies": {
"@azure/communication-calling": "1.32.2-beta.1 || ^1.31.2",
"@azure/communication-calling": "1.32.2-beta.1 || ^1.32.1",
"@azure/core-auth": "^1.7.2",
"@babel/cli": "^7.24.8",
"@babel/core": "^7.25.2",
Expand Down
Loading

0 comments on commit fa1823f

Please sign in to comment.