Minor testing improvements #4483
Merged
+49
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
super-harsh
approved these changes
Dec 3, 2024
| @@ -60,7 +64,7 @@ kubectl wait --for=condition=ready --timeout=3m pod -n "$OPERATOR_NAMESPACE" -l | |||
| echo "Waiting for CRD cabundle..." | |||
| export -f all_crds_have_cabundle | |||
| export -f wait_for_crds_cabundle | |||
| timeout 2m bash -c wait_for_crds_cabundle | |||
| timeout 8m bash -c wait_for_crds_cabundle | |||
There was a problem hiding this comment.
Isn't 8 mins from 2 too high?
Just thinking about if something else goes haywire then it waits for 4x longer than it used to.
There was a problem hiding this comment.
I incremented from 2m by 1m steps; things finally worked end to end at 7m, so I added one more for a little headroom.
Totally agree that this should be no higher than necessary.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Split the
format-codetask into separate targets, avoiding the problem wheregolangci-lintsometimes fails when applying fixes within a submodule.Improved logging in
create-kind-wi-storage.shfor better traceability and debugging.Improved logging and increased timeouts
wait-for-operator-ready.shto provide more context.How does this PR make you feel?