Include golangci-lint fixes when formatting code #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
matthchr
approved these changes
Nov 22, 2024
matthchr
reviewed
Nov 22, 2024
| @@ -103,6 +103,7 @@ tasks: | |||
| desc: Ensure all code is formatted | |||
| dir: v2 | |||
| cmds: | |||
| - golangci-lint run --fix ./... | |||
There was a problem hiding this comment.
This is called both in the ci task and the local task default. Do we want it executed in both - is the experience w/ this changing code in CI good?
There was a problem hiding this comment.
Maybe we should change the verify-no-changes task to have an error that gives the cmd to run to fix things up?
There was a problem hiding this comment.
Good idea. Done.
matthchr
approved these changes
Nov 22, 2024
| @@ -103,6 +103,7 @@ tasks: | |||
| desc: Ensure all code is formatted | |||
| dir: v2 | |||
| cmds: | |||
| - golangci-lint run --fix ./... | |||
There was a problem hiding this comment.
Maybe we should change the verify-no-changes task to have an error that gives the cmd to run to fix things up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Now that we're enforcing import order using gci, the exacting rule means getting a pull request across the line might be challenging.
Fortunately, there's an automated fix that we can apply by running
golangci-lintwith the--fixparameter. Adding this to theformat-codetask in theTaskfile.ymlmakes this easy to access.How does this PR make you feel?