Loosen up Owner-Child resource subscription checks #4343
Merged
+224
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
|
@theunrepentantgeek I've made the change as per above. |
theunrepentantgeek
approved these changes
Oct 21, 2024
matthchr
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3754
What this PR does / why we need it:
We introduced this check a while ago with single-operator multitenancy credentials to prevent users from creating resources in a subscription that doesn't match the subscription of the owner resource. However, there could be scenarios where owner and child resources could be provisioned in distinct subscriptions.
This PR is to loosen up check between Owner-Child resource subscription mismatch for ARMID owner references. From a security perspective Azure has access checks and the operation is not allowed, it'll be rejected at ARM level.
Special notes for your reviewer:
Will add documentation after we make a decision on taking the change
If applicable: