[core] Add optional agent option to WebResourceLike
#32590
+69
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add plubming to pass it to core-rest-pipeline. Also add agent and tlsSettings to PipelineRequestOptions.
jeremymeng
commented
Jan 16, 2025
| * A Node-only option to provide a custom `http.Agent`/`https.Agent`. | ||
| * Does nothing when running in the browser. | ||
| */ | ||
| agent?: Agent; |
There was a problem hiding this comment.
Do we have a specific reason why we don't have agent and tlsSettings in PipelineRequestOptions, or we missed adding them?
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add plubming to pass it to core-rest-pipeline.
Also add agent and tlsSettings to PipelineRequestOptions.