[core] Introducing core-websockets #32555
Conversation
deyaaeldeen
force-pushed
the
feat/websockets
branch
from
b28b84b to
6fe5433
Compare
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
deyaaeldeen
force-pushed
the
feat/websockets
branch
from
6fe5433 to
b169150
Compare
| throw compileErrors(errors); | ||
| } | ||
|
|
||
| function compileErrors(errors: unknown[]): Error { |
There was a problem hiding this comment.
Would be nicer if we could use ES2021 and AggregateError
| | Uint8Array | ||
| | ArrayBuffer | ||
| | SharedArrayBuffer | ||
| | readonly any[] |
There was a problem hiding this comment.
should any[] be included? Feels strange if arbitrary shapes of objects are allowed. For number do we only allow a single byte, or treat it as multiple bytes? Also for number[] what about numbers that are bigger than uint8?
| { | ||
| "name": "@azure/core-websockets", | ||
| "version": "1.0.0-beta.1", | ||
| "description": "Implementation of a websockets client for Node.js and browsers.", |
There was a problem hiding this comment.
Nit: I am not too sure about this. Should we call this implementation of websockets client, or enhancement?
| /** | ||
| * Types that are compatible with NodeJS Buffer. | ||
| */ | ||
| export type BufferLike = |
There was a problem hiding this comment.
Will we have a browser version too since some type Buffer is not available in browsers. Or should we have the common one ArrayBufferLike
deyaaeldeen
force-pushed
the
feat/websockets
branch
from
b169150 to
4708384
Compare
deyaaeldeen
force-pushed
the
feat/websockets
branch
from
4708384 to
5b75cc8
Compare
WIP