Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EngSys] upgrade dev dependency mocha to ^11.0.2 #32129

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[EngSys] upgrade dev dependency mocha to ^11.0.2 #32129

merged 1 commit into from
Dec 10, 2024

Conversation

jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented Dec 9, 2024 •
edited
Loading

v11 drops supports for NodeJS < 18.18.0, it doesn't impact us.

NO_CI

@jeremymeng
[EngSys] upgrade dev dependency mocha to ^11.0.2
6a04fa2 
v11 drops supports for NodeJS < 18, it doesn't impact us.

***NO_CI***
@github-actions github-actions bot added Batch Cognitive - Translator Cosmos eslint plugin Farmbeats Mgmt This issue is related to a management-plane library. Microsoft Playwright Testing Storage Storage Service (Queues, Blobs, Files) test-utils Label for the issues related to the @azure/test-utils package labels Dec 9, 2024
@mpodwysocki
Copy link
Member

@jeremymeng be aware that it is down to 18.18.0 and not to 18 overall as per mochajs/mocha#5216

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jeremymeng
Copy link
Member Author

@jeremymeng be aware that it is down to 18.18.0 and not to 18 overall as per mochajs/mocha#5216

Yes. I think for us it should be fine.

@jeremymeng
Copy link
Member Author

agrifood-farming, policy - mgmt, arm-commerce: all existing test failures

@jeremymeng jeremymeng merged commit 3dfc94b into Azure:main Dec 10, 2024
188 of 202 checks passed
@jeremymeng jeremymeng deleted the engsys/mocha-v11 branch December 10, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpodwysocki mpodwysocki mpodwysocki approved these changes

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

@JacksonWeber JacksonWeber Awaiting requested review from JacksonWeber JacksonWeber is a code owner

@harsimar harsimar Awaiting requested review from harsimar harsimar is a code owner

@Sid200026 Sid200026 Awaiting requested review from Sid200026 Sid200026 is a code owner

@puagarwa puagarwa Awaiting requested review from puagarwa puagarwa is a code owner

@ShreyaAnand ShreyaAnand Awaiting requested review from ShreyaAnand ShreyaAnand is a code owner

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru HarshaNalluru is a code owner

@timovv timovv Awaiting requested review from timovv timovv is a code owner

@hamshavathimunibyraiah hamshavathimunibyraiah Awaiting requested review from hamshavathimunibyraiah hamshavathimunibyraiah is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@EmmaZhu EmmaZhu Awaiting requested review from EmmaZhu EmmaZhu is a code owner

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu XiaoningLiu is a code owner

@vinjiang vinjiang Awaiting requested review from vinjiang vinjiang is a code owner

@jiacfan jiacfan Awaiting requested review from jiacfan jiacfan is a code owner

@ljian3377 ljian3377 Awaiting requested review from ljian3377 ljian3377 is a code owner

@blueww blueww Awaiting requested review from blueww blueww is a code owner

@amanrao23 amanrao23 Awaiting requested review from amanrao23 amanrao23 is a code owner

@aditishree1 aditishree1 Awaiting requested review from aditishree1 aditishree1 is a code owner

@sajeetharan sajeetharan Awaiting requested review from sajeetharan sajeetharan is a code owner

@topshot99 topshot99 Awaiting requested review from topshot99 topshot99 is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

Assignees
No one assigned
Labels
Batch Cognitive - Translator Cosmos eslint plugin Farmbeats Mgmt This issue is related to a management-plane library. Microsoft Playwright Testing Storage Storage Service (Queues, Blobs, Files) test-utils Label for the issues related to the @azure/test-utils package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremymeng @mpodwysocki @azure-sdk