Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase DefaultElasticBoundSize to Stress All Tests #43519

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Increase DefaultElasticBoundSize to Stress All Tests #43519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08789f5
adding check to make sure RuntimeException isn't thrown
ibrahimrabab Dec 13, 2024
5683860
testing all scenarios with ElasticBound value
ibrahimrabab Dec 19, 2024
d60f125
uncommenting tests
ibrahimrabab Dec 19, 2024
4672722
adding all tests back to see if everything runs with new elsastic bou…
ibrahimrabab Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-blob-stress/templates/stress-test-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ spec:
-XX:MaxRAMPercentage=50 \
-XX:+HeapDumpOnOutOfMemoryError \
-XX:HeapDumpPath="${DEBUG_SHARE}" \
-Dreactor.schedulers.defaultBoundedElasticSize={{ default 5 .Stress.parallelRuns }} \
-Dreactor.schedulers.defaultBoundedElasticSize={{ 25 }} \
-jar /app/azure-storage-blob-stress-1.0.0-beta.1-jar-with-dependencies.jar \
{{ .Stress.testScenario }} \
--parallel {{ default 5 .Stress.parallelRuns }} \
--parallel {{ default 3 .Stress.parallelRuns }} \
--maxConcurrency {{ default 10 .Stress.maxConcurrency }} \
--duration {{ mul 60 .Stress.durationMin }} \
--size {{ .Stress.sizeBytes }} \
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-file-datalake-stress/templates/stress-test-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ spec:
-XX:MaxRAMPercentage=50 \
-XX:+HeapDumpOnOutOfMemoryError \
-XX:HeapDumpPath="${DEBUG_SHARE}" \
-Dreactor.schedulers.defaultBoundedElasticSize={{ default 5 .Stress.parallelRuns }} \
-Dreactor.schedulers.defaultBoundedElasticSize={{ 25 }} \
-jar /app/azure-storage-file-datalake-stress-1.0.0-beta.1-jar-with-dependencies.jar \
{{ .Stress.testScenario }} \
--parallel {{ default 5 .Stress.parallelRuns }} \
--parallel {{ default 3 .Stress.parallelRuns }} \
--maxConcurrency {{ default 10 .Stress.maxConcurrency }} \
--duration {{ mul 60 .Stress.durationMin }} \
--size {{ .Stress.sizeBytes }} \
Expand Down
2 changes: 1 addition & 1 deletion ...file-share-stress/src/main/java/com/azure/storage/file/share/stress/FileOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ protected void runInternal(Context span) throws IOException {

try (CrcInputStream inputStream = new CrcInputStream(originalContent.getContentHead(), options.getSize());
OutputStream outputStream = syncClient.getFileOutputStream()) {
byte[] buffer = new byte[4096]; // Define a buffer
byte[] buffer = new byte[1024*1024*4]; // Define a buffer
int bytesRead;

// Read from the inputStream and write to the blobOutputStream
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-file-share-stress/templates/stress-test-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ spec:
-XX:MaxRAMPercentage=50 \
-XX:+HeapDumpOnOutOfMemoryError \
-XX:HeapDumpPath="${DEBUG_SHARE}" \
-Dreactor.schedulers.defaultBoundedElasticSize={{ default 5 .Stress.parallelRuns }} \
-Dreactor.schedulers.defaultBoundedElasticSize={{ 25 }} \
-jar /app/azure-storage-file-share-stress-1.0.0-beta.1-jar-with-dependencies.jar \
{{ .Stress.testScenario }} \
--parallel {{ default 5 .Stress.parallelRuns }} \
--parallel {{ default 3 .Stress.parallelRuns }} \
--maxConcurrency {{ default 10 .Stress.maxConcurrency }} \
--duration {{ mul 60 .Stress.durationMin }} \
--size {{ .Stress.sizeBytes }} \
Expand Down
16 changes: 15 additions & 1 deletion sdk/storage/azure-storage-stress/src/main/java/com/azure/storage/stress/TelemetryHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import com.azure.core.util.logging.ClientLogger;
import com.azure.core.util.logging.LogLevel;
import com.azure.monitor.opentelemetry.exporter.AzureMonitorExporter;
import io.netty.channel.unix.Errors;
import io.opentelemetry.api.OpenTelemetry;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.common.Attributes;
Expand Down Expand Up @@ -195,9 +196,22 @@ private void trackCancellation(Instant start, Span span) {
private void trackFailure(Instant start, Throwable e, Span span) {
Throwable unwrapped = Exceptions.unwrap(e);

// Check if the message contains "NativeIoException" and the unwrapped exception is not already a NativeIoException

// Check if the unwrapped exception is a RuntimeException
if (unwrapped instanceof RuntimeException) {
String message = unwrapped.getMessage();
if (message.contains("NativeIoException")) {
unwrapped = new io.netty.channel.unix.Errors.NativeIoException("recvAddress", Errors.ERRNO_ECONNRESET_NEGATIVE);
} else if (message.contains("TimeoutException")) {
unwrapped = new TimeoutException(message);
}
// may need to add more known exceptions here
}

span.recordException(unwrapped);
span.setAttribute(ERROR_TYPE_ATTRIBUTE, unwrapped.getClass().getName());
span.setStatus(StatusCode.ERROR, unwrapped.getMessage());
span.setStatus(StatusCode.ERROR, unwrapped.getMessage()); // add check here to see if its a connection reset exception/NativeIoException

String errorType = unwrapped.getClass().getName();
logger.atError()
Expand Down
Loading