Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup RestProxy code #43503

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Cleanup RestProxy code #43503

merged 2 commits into from
Dec 20, 2024

Conversation

alzimmermsft
Copy link
Member

Description

Cleans up RestProxy related code as it was copied from azure-core which has much more complex requirements than clientcore.

Merges RestProxyBase and RestProxyUtils into RestProxyImpl and removed any inheritance.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Dec 19, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

samvaity
samvaity approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alzimmermsft alzimmermsft merged commit 6c1394d into Azure:main Dec 20, 2024
16 checks passed
@alzimmermsft alzimmermsft deleted the AzCC_CleanupRestProxyCode branch December 20, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity samvaity approved these changes

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
clientcore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @azure-sdk @samvaity