Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] a simple PagedIterable / PagedResponse #43484

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,206 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package io.clientcore.core.http.models;

import io.clientcore.core.util.ClientLogger;

import java.util.Iterator;
import java.util.NoSuchElementException;
import java.util.Queue;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.Function;
import java.util.function.Supplier;
import java.util.stream.Stream;
import java.util.stream.StreamSupport;

/**
* This class provides utility to iterate over {@link PagedResponse} using {@link Stream} and {@link Iterable}
* interfaces.
*
* @param <T> The type of items in the page.
*/
public final class PagedIterable<T> implements Iterable<T> {

private final Function<String, PagedResponse<T>> pageRetriever;

/**
* Creates an instance of {@link PagedIterable} that consists of only a single page. This constructor takes a {@code
* Supplier} that return the single page of {@code T}.
*
* @param firstPageRetriever Supplier that retrieves the first page.
*/
public PagedIterable(Supplier<PagedResponse<T>> firstPageRetriever) {
this(firstPageRetriever, null);
}

/**
* Creates an instance of {@link PagedIterable}. The constructor takes a {@code Supplier} and {@code Function}. The
* {@code Supplier} returns the first page of {@code T}, the {@code Function} retrieves subsequent pages of {@code
* T}.
*
* @param firstPageRetriever Supplier that retrieves the first page.
* @param nextPageRetriever Function that retrieves the next page given a continuation token
*/
public PagedIterable(Supplier<PagedResponse<T>> firstPageRetriever,
Function<String, PagedResponse<T>> nextPageRetriever) {
this.pageRetriever = (continuationToken) -> (continuationToken == null)
? firstPageRetriever.get()
: nextPageRetriever.apply(continuationToken);
}

/**
* {@inheritDoc}
*/
@Override
public Iterator<T> iterator() {
return iterableByItemInternal().iterator();
}

/**
* Retrieve the {@link Iterable}, one page at a time. It will provide same {@link Iterable} of T values from
* starting if called multiple times.
*
* @return {@link Iterable} of a pages
*/
public Iterable<PagedResponse<T>> iterableByPage() {
return iterableByPageInternal();
}

/**
* Utility function to provide {@link Stream} of value {@code T}.
*
* @return {@link Stream} of value {@code T}.
*/
public Stream<T> stream() {
return StreamSupport.stream(iterableByItemInternal().spliterator(), false);
}

/**
* Retrieve the {@link Stream}, one page at a time. It will provide same {@link Stream} of T values from starting if
* called multiple times.
*
* @return {@link Stream} of a pages
*/
public Stream<PagedResponse<T>> streamByPage() {
return StreamSupport.stream(iterableByPage().spliterator(), false);
}

private Iterable<T> iterableByItemInternal() {
return () -> new PagedByIterator<>(pageRetriever) {

private final Queue<Iterator<T>> pages = new ConcurrentLinkedQueue<>();
private volatile Iterator<T> currentPage;

@Override
boolean needToRequestPage() {
return (currentPage == null || !currentPage.hasNext()) && pages.peek() == null;
}

@Override
boolean isNextAvailable() {
return (currentPage != null && currentPage.hasNext()) || pages.peek() != null;
}

@Override
T getNext() {
if ((currentPage == null || !currentPage.hasNext()) && pages.peek() != null) {
currentPage = pages.poll();
}

return currentPage.next();
}

@Override
void addPage(PagedResponse<T> page) {
Iterator<T> pageValues = page.getValue().iterator();
if (pageValues.hasNext()) {
this.pages.add(pageValues);
}
}
};
}

private Iterable<PagedResponse<T>> iterableByPageInternal() {
return () -> new PagedByIterator<T, PagedResponse<T>>(pageRetriever) {

private final Queue<PagedResponse<T>> pages = new ConcurrentLinkedQueue<>();

@Override
boolean needToRequestPage() {
return pages.peek() == null;
}

@Override
boolean isNextAvailable() {
return pages.peek() != null;
}

@Override
PagedResponse<T> getNext() {
return pages.poll();
}

@Override
void addPage(PagedResponse<T> page) {
this.pages.add(page);
}
};
}

private abstract static class PagedByIterator<T, E> implements Iterator<E> {
private static final ClientLogger LOGGER = new ClientLogger(PagedByIterator.class);

private final Function<String, PagedResponse<T>> pageRetriever;
private volatile String continuationToken;
private volatile boolean done;

PagedByIterator(Function<String, PagedResponse<T>> pageRetriever) {
this.pageRetriever = pageRetriever;
}

@Override
public E next() {
if (!hasNext()) {
throw LOGGER.logThrowableAsError(new NoSuchElementException("Iterator contains no more elements."));
}

return getNext();
}

@Override
public boolean hasNext() {
// Request next pages in a loop in case we are returned empty pages for the by item implementation.
while (!done && needToRequestPage()) {
requestPage();
}

return isNextAvailable();
}

abstract boolean needToRequestPage();

abstract boolean isNextAvailable();

abstract E getNext();

synchronized void requestPage() {
AtomicBoolean receivedPages = new AtomicBoolean(false);
PagedResponse<T> page = pageRetriever.apply(continuationToken);
if (page != null) {
receivePage(receivedPages, page);
}
}

abstract void addPage(PagedResponse<T> page);

private void receivePage(AtomicBoolean receivedPages, PagedResponse<T> page) {
receivedPages.set(true);
addPage(page);

continuationToken = page.getNextLink();
this.done = continuationToken == null || continuationToken.isEmpty();
}
Comment on lines +198 to +204
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The receivePage (and related var) would be different, if server support both continuationToken and nextLink.

SDK likely would only provide one pageRetriever with either of the approach. It may also provide a e.g. continuationTokenRetriever to specify whether to call getNextLink or getContinuationToken.

}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package io.clientcore.core.http.models;

import io.clientcore.core.util.binarydata.BinaryData;

import java.io.IOException;
import java.util.List;

/**
* Response of a REST API that returns page.
*
* @see Response
*
* @param <T> The type of items in the page.
*/
public final class PagedResponse<T> implements Response<List<T>> {
Copy link
Member Author

@weidongxu-microsoft weidongxu-microsoft Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For azure-core, the PagedResponse is an interface. The implementation is in PagedResponseBase. Should we do the same for clientcore?

In such case, we can even generate the implementation class in emitter (so clientcore does not need to have the PagedResponseBase class).


private final HttpRequest request;
private final int statusCode;
private final HttpHeaders headers;
private final List<T> items;
private final String nextLink;
private final BinaryData body;

/**
* Creates a new instance of the PagedResponse type.
*
* @param request The HttpRequest that was sent to the service whose response resulted in this response.
* @param statusCode The status code from the response.
* @param headers The headers from the response.
* @param body The body from the response.
* @param items The items returned from the service within the response.
* @param nextLink The next page reference returned from the service, to enable future requests to pick up
* from the same place in the paged iteration.
*/
public PagedResponse(HttpRequest request, int statusCode, HttpHeaders headers, BinaryData body, List<T> items,
String nextLink) {
this.request = request;
this.statusCode = statusCode;
this.headers = headers;
this.body = body;
this.items = items;
this.nextLink = nextLink;
}

/**
* Gets the reference to the next page.
*
* @return The next page reference or null if there isn't a next page.
*/
public String getNextLink() {
return nextLink;
}

// TODO
// public String getContinuationToken() {}
// public String getPreviousLink() {}
// public String getFirstLink() {}
// public String getLastLink() {}

/**
* {@inheritDoc}
*/
@Override
public int getStatusCode() {
return statusCode;
}

/**
* {@inheritDoc}
*/
@Override
public HttpHeaders getHeaders() {
return headers;
}

/**
* {@inheritDoc}
*/
@Override
public HttpRequest getRequest() {
return request;
}

/**
* {@inheritDoc}
*/
@Override
public List<T> getValue() {
return items;
}

/**
* {@inheritDoc}
*/
@Override
public BinaryData getBody() {
return body;
}

/**
* {@inheritDoc}
*/
@Override
public void close() throws IOException {
if (body != null) {
body.close();
}
}
}
Loading