Implement SAS-based authentication #43448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. com.azure:azure-maps-route |
dubiety
reviewed
Dec 19, 2024
...zure-maps-geolocation/src/main/java/com/azure/maps/geolocation/GeolocationClientBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- sdk/maps/azure-maps-geolocation/src/main/java/com/azure/maps/geolocation/GeolocationClientBuilder.java: Evaluated as low risk
- sdk/maps/azure-maps-render/CHANGELOG.md: Evaluated as low risk
- sdk/maps/azure-maps-render/src/main/java/com/azure/maps/render/MapsRenderClientBuilder.java: Evaluated as low risk
- sdk/maps/azure-maps-route/CHANGELOG.md: Evaluated as low risk
- sdk/maps/azure-maps-route/src/main/java/com/azure/maps/route/MapsRouteClientBuilder.java: Evaluated as low risk
- sdk/maps/azure-maps-search/CHANGELOG.md: Evaluated as low risk
- sdk/maps/azure-maps-search/src/main/java/com/azure/maps/search/MapsSearchClientBuilder.java: Evaluated as low risk
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 20 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- sdk/maps/azure-maps-search/pom.xml: Language not supported
- sdk/maps/azure-maps-timezone/src/main/java/com/azure/maps/timezone/TimeZoneClientBuilder.java: Evaluated as low risk
- sdk/maps/azure-maps-timezone/CHANGELOG.md: Evaluated as low risk
- sdk/maps/azure-maps-weather/CHANGELOG.md: Evaluated as low risk
- sdk/maps/azure-maps-render/src/main/java/com/azure/maps/render/MapsRenderClientBuilder.java: Evaluated as low risk
- sdk/maps/azure-maps-geolocation/src/main/java/com/azure/maps/geolocation/GeolocationClientBuilder.java: Evaluated as low risk
- sdk/maps/azure-maps-search/src/main/java/com/azure/maps/search/MapsSearchClientBuilder.java: Evaluated as low risk
- sdk/maps/azure-maps-route/src/main/java/com/azure/maps/route/MapsRouteClientBuilder.java: Evaluated as low risk
- sdk/maps/README.md: Evaluated as low risk
- sdk/maps/azure-maps-weather/src/main/java/com/azure/maps/weather/WeatherClientBuilder.java: Evaluated as low risk
- sdk/maps/azure-maps-geolocation/CHANGELOG.md: Evaluated as low risk
- sdk/maps/azure-maps-route/CHANGELOG.md: Evaluated as low risk
- sdk/maps/azure-maps-timezone/README.md: Evaluated as low risk
- sdk/maps/azure-maps-route/README.md: Evaluated as low risk
- sdk/maps/azure-maps-render/README.md: Evaluated as low risk
Comments suppressed due to low confidence (1)
sdk/maps/azure-maps-geolocation/README.md:65
- The line contains a typo: 'TThe' should be corrected to 'The'.
TThe sample code assumes global Azure. Please change `AzureEnvironment.AZURE` variable if otherwise.
dubiety
approved these changes
Dec 19, 2024
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
dubiety
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.