Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sum support for annotated queries #43239

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

trande4884
Copy link
Member

@trande4884 trande4884 commented Dec 5, 2024

Description

This PR is to add sum() support for annotated queries in azure-spring-data-cosmos. For performance reasons, columns being used for sum() should be indexed.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Dec 5, 2024
@trande4884 trande4884 linked an issue Dec 19, 2024 that may be closed by this pull request
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Please update the PR description and address the NIt comment I left. The PR description should probably call out that it is critical (perf-wise) to have the columns summed or used for filters being indexed.

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @trande4884 thanks!
Please also update the readme section with the indexing part required for sum queries otherwise it will be a performance issue.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-spring-data-cosmos

@trande4884
Copy link
Member Author

/azp run java - spring - cosmos - tests

@Azure Azure deleted a comment from azure-pipelines bot Dec 21, 2024
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]
4 participants