-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding sum support for annotated queries #43239
base: main
Are you sure you want to change the base?
Conversation
…e_sumAnnotatedQuerySupport
...azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/core/CosmosTemplate.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Please update the PR description and address the NIt comment I left. The PR description should probably call out that it is critical (perf-wise) to have the columns summed or used for filters being indexed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @trande4884 thanks!
Please also update the readme section with the indexing part required for sum queries otherwise it will be a performance issue.
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run java - spring - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
This PR is to add sum() support for annotated queries in azure-spring-data-cosmos. For performance reasons, columns being used for sum() should be indexed.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines