Fixing the Network Virtual Appliance Restart Http return code to match the REST API #28959

arsheen · 2024-05-03T00:52:30Z

Please review the same changes being added to the current release(2024-01-01) as well:
#29048

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-05-03T00:52:33Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
ARM review workflow label is missing! Add /azp run comment to this PR to allow automation to determine where this PR is in the ARM review workflow.
For details of the ARM review, see aka.ms/azsdk/pr-arm-review.

openapi-pipeline-app · 2024-05-03T00:52:34Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.8)	new version	base version
networkVirtualAppliance.json	2023-11-01(35938ab)	2023-11-01(main)

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L333:11
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L289:7 Old: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L289:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-2023-11-preview	package-2023-11-preview(35938ab)	package-2023-11-preview(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L37
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L38
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L105
`❌` PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L181
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L288
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L448
`❌` ResourceNameRestriction	The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L448
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L449
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L488
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L641
`❌` PathForTrackedResourceTypes	The path must be under a subscription and resource group for tracked resource types. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L733
`❌` ResourceNameRestriction	The resource name parameter 'skuName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L733
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L776
`❌` ResourceNameRestriction	The resource name parameter 'ruleCollectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L776
`❌` MissingTypeObject	The schema 'NetworkVirtualAppliance' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L851
`❌` MissingTypeObject	The schema 'NetworkVirtualAppliancePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L875
`❌` MissingTypeObject	The schema 'VirtualApplianceSkuProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1011
`❌` MissingTypeObject	The schema 'VirtualApplianceNicProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1031
`❌` MissingTypeObject	The schema 'VirtualApplianceSite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1169
`❌` MissingTypeObject	The schema 'VirtualApplianceSiteProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1198
`❌` MissingTypeObject	The schema 'Office365PolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1218
`❌` MissingTypeObject	The schema 'BreakOutCategoryPolicies' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1228
`❌` AllTrackedResourcesMustHaveDelete	The resource NetworkVirtualApplianceSku does not have a corresponding delete operation. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1248
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceSku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1248
`❌` TrackedResourcePatchOperation	Tracked resource 'NetworkVirtualApplianceSku' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1248
`❌` TrackedResourcesMustHavePut	The tracked resource NetworkVirtualApplianceSku does not have a corresponding put operation. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1248
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceSkuPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1269
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceSkuInstances' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1295
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1312
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceSiteListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1328

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-03T00:52:35Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️❌ azure-sdk-for-net failed [Detail]

❌Code Generator Failed in generating from b34f10cdfb9b68cb77ba49cab5aa6a9b9691286d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Network [Preview SDK Changes]

cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]      1>/home/cloudtest/.nuget/packages/microsoft.internal.netsdkbuild.mgmt.tools/0.12.0-dev.20220216.1/targets/common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/mnt/vss/_work/1/s/azure-sdk-for-net/eng/mgmt.proj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /home/cloudtest/.nuget/packages/microsoft.internal.netsdkbuild.mgmt.tools/0.12.0-dev.20220216.1/targets/common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/mnt/vss/_work/1/s/azure-sdk-for-net/eng/mgmt.proj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded in generating from b34f10cdfb9b68cb77ba49cab5aa6a9b9691286d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Network [Preview SDK Changes]
- Azure.ResourceManager.Network.1.8.0-alpha.20240515.1.nupkg
```
info	[Changelog]
```

️🔄 azure-sdk-for-python inProgress [Detail]

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from b34f10cdfb9b68cb77ba49cab5aa6a9b9691286d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-network-generated-1.0.0-beta.1.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from b34f10cdfb9b68cb77ba49cab5aa6a9b9691286d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
info	[Changelog] - New enum type `InboundSecurityRuleType` with values `InboundSecurityRuleTypeAutoExpire`, `InboundSecurityRuleTypePermanent`
info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
info	[Changelog] - New function `*VirtualAppliancesClient.BeginRestart(context.Context, string, string, *VirtualAppliancesClientBeginRestartOptions) (*runtime.Poller[VirtualAppliancesClientRestartResponse], error)`
info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
info	[Changelog] - New struct `FirewallPolicyDraft`
info	[Changelog] - New struct `FirewallPolicyDraftProperties`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
info	[Changelog] - New struct `HeaderValueMatcher`
info	[Changelog] - New struct `PacketCaptureSettings`
info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
info	[Changelog] - New field `RuleType` in struct `InboundSecurityRuleProperties`
info	[Changelog] - New field `AppliesOn`, `DestinationPortRanges`, `Name` in struct `InboundSecurityRules`
info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 73 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from b34f10cdfb9b68cb77ba49cab5aa6a9b9691286d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [Preview SDK Changes]

azure-arm-network-33.2.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group FirewallPolicyDeployments
info	[Changelog]   - Added operation group FirewallPolicyDrafts
info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
info	[Changelog]   - Added operation NetworkVirtualAppliances.beginRestart
info	[Changelog]   - Added operation NetworkVirtualAppliances.beginRestartAndWait
info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraft
info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
info	[Changelog]   - Added Interface HeaderValueMatcher
info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartHeaders
info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
info	[Changelog]   - Added Interface PacketCaptureSettings
info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
info	[Changelog]   - Added Type Alias InboundSecurityRuleType
info	[Changelog]   - Added Type Alias NetworkVirtualAppliancesRestartResponse
info	[Changelog]   - Added Type Alias NicTypeInRequest
info	[Changelog]   - Added Type Alias NicTypeInResponse
info	[Changelog]   - Added Type Alias SharingScope
info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
info	[Changelog]   - Interface InboundSecurityRule has a new optional parameter ruleType
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter appliesOn
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter destinationPortRanges
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter name
info	[Changelog]   - Interface NetworkInterfaceIPConfiguration has a new optional parameter privateIPAddressPrefixLength
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
info	[Changelog]   - Added Enum KnownInboundSecurityRuleType
info	[Changelog]   - Added Enum KnownNicTypeInRequest
info	[Changelog]   - Added Enum KnownNicTypeInResponse
info	[Changelog]   - Added Enum KnownSharingScope
info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork

️❌ azure-resource-manager-schemas failed [Detail]

❌Code Generator Failed in generating from b34f10cdfb9b68cb77ba49cab5aa6a9b9691286d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

️⚠️ azure-powershell warning [Detail]

⚠️Warning in generating from b34f10cdfb9b68cb77ba49cab5aa6a9b9691286d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.network.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-03T00:52:35Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/1b263a329090477991c0a7b7b0ae21d7?revisionId=955aadfca5754c408bf9e62c2df5f3a7
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/d496e631581f47bcab5c961219fc2258?revisionId=bfb32a0efec94e84a4aea5d38da35f94
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=62c5f17883cb44a38e2f8dc61606e98b
.Net	Azure.ResourceManager.Network	https://apiview.dev/Assemblies/Review/806ead8231374028b5c49cb90e200641?revisionId=7d4f8828f4f849919cd8ba45beb14864
Swagger	Microsoft.Network	https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=fcc96e60520c4ddca74f2e728e4a16ee

arsheen · 2024-05-06T18:36:03Z

/azp run

azure-pipelines · 2024-05-06T18:36:21Z

Azure Pipelines successfully started running 4 pipeline(s).

…h the REST API

openapi-pipeline-app · 2024-05-06T18:59:01Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

arsheen · 2024-05-15T17:52:37Z

/azp run

azure-pipelines · 2024-05-15T17:52:43Z

Commenter does not have sufficient privileges for PR 28959 in repo Azure/azure-rest-api-specs

…ance

arsheen · 2024-05-15T18:26:29Z

/azp run

azure-pipelines · 2024-05-15T18:26:35Z

Commenter does not have sufficient privileges for PR 28959 in repo Azure/azure-rest-api-specs

arsheen · 2024-05-15T19:00:13Z

/pr RequestMerge

…h the REST API (Azure#28959) * Fixing the Netwotk Virtual Appliance Restart Http return code to match the REST API * Adding a header to the description * Fixing error * Fixing check failures * Adding examples * Add schema to the 200 response * Adding schema to examples and 202 * Remove schema for 202 --------- Co-authored-by: Arsheen Khatib <[email protected]>

arsheen requested a review from Joanna-Yang-Art as a code owner May 3, 2024 00:52

arsheen added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ARMReview labels May 3, 2024

AzureRestAPISpecReview added NotReadyForARMReview resource-manager labels May 3, 2024

azure-sdk mentioned this pull request May 3, 2024

[AutoPR Microsoft.Azure.Management.Network] Fixing the Network Virtual Appliance Restart Http return code to match the REST API azure-sdk/azure-sdk-for-net#7901

Closed

arsheen changed the title ~~Fixing the Netwotk Virtual Appliance Restart Http return code to match the REST API~~ Fixing the Network Virtual Appliance Restart Http return code to match the REST API May 6, 2024

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label May 6, 2024

mikekistler added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label May 6, 2024

Arsheen Khatib added 8 commits May 6, 2024 11:52

Fixing the Netwotk Virtual Appliance Restart Http return code to matc…

d98558e

…h the REST API

Adding a header to the description

73c4659

Fixing error

093f231

Fixing check failures

d6922d9

Adding examples

bf73dee

Add schema to the 200 response

a92eb62

Adding schema to examples and 202

5789aa3

Remove schema for 202

27b5fa8

arsheen force-pushed the akhatib/hotfix-restart-network-virtual-appliance branch from 1a7448a to 27b5fa8 Compare May 6, 2024 18:52

AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels May 6, 2024

arsheen added do-not-merge MergeRequested and removed do-not-merge MergeRequested labels May 7, 2024

arsheen mentioned this pull request May 9, 2024

Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 #29048

Merged

7 tasks

mentat9 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 15, 2024

Merge branch 'main' into akhatib/hotfix-restart-network-virtual-appli…

35938ab

…ance

microsoft-github-policy-service bot added the MergeRequested label May 15, 2024

mentat9 self-requested a review May 16, 2024 00:56

mentat9 approved these changes May 16, 2024

View reviewed changes

mentat9 merged commit 222ecb7 into Azure:main May 16, 2024
27 of 32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing the Network Virtual Appliance Restart Http return code to match the REST API #28959

Fixing the Network Virtual Appliance Restart Http return code to match the REST API #28959

arsheen commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

arsheen commented May 6, 2024

azure-pipelines bot commented May 6, 2024

openapi-pipeline-app bot commented May 6, 2024 •

edited

Loading

arsheen commented May 15, 2024

azure-pipelines bot commented May 15, 2024

arsheen commented May 15, 2024

azure-pipelines bot commented May 15, 2024

arsheen commented May 15, 2024

Fixing the Network Virtual Appliance Restart Http return code to match the REST API #28959

Fixing the Network Virtual Appliance Restart Http return code to match the REST API #28959

Conversation

arsheen commented May 3, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented May 3, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented May 3, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 3, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented May 3, 2024 • edited Loading

Generated ApiView

arsheen commented May 6, 2024

azure-pipelines bot commented May 6, 2024

openapi-pipeline-app bot commented May 6, 2024 • edited Loading

Next Steps to Merge

arsheen commented May 15, 2024

azure-pipelines bot commented May 15, 2024

arsheen commented May 15, 2024

azure-pipelines bot commented May 15, 2024

arsheen commented May 15, 2024

arsheen commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 6, 2024 •

edited

Loading