Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Instance Pool API version to preview 2023-05-01 #26666

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/sql/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ These are the global settings for the Sql API.
title: SqlManagementClient
description: 'The Azure SQL Database management API provides a RESTful set of web services that interact with Azure SQL Database services to manage your databases. The API enables you to create, retrieve, update, and delete databases.'
openapi-type: arm
tag: package-preview-2023-05
tag: package-composite-v5
```
### Composite packages
Expand Down Expand Up @@ -1174,7 +1174,6 @@ input-file:
- ./Microsoft.Sql/preview/2020-11-01-preview/ElasticPoolOperations.json
- ./Microsoft.Sql/preview/2020-11-01-preview/EncryptionProtectors.json
- ./Microsoft.Sql/preview/2020-11-01-preview/FirewallRules.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also modify Line 27 tag to "package-composite-v5"

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the revert and corresponding failed pipeline, please check my comment in another PR: #26683 (comment)

You could either add it or wait #26683 (comment) merge.

- ./Microsoft.Sql/preview/2020-11-01-preview/InstancePools.json
- ./Microsoft.Sql/preview/2020-11-01-preview/JobAgents.json
- ./Microsoft.Sql/preview/2020-11-01-preview/JobCredentials.json
- ./Microsoft.Sql/preview/2020-11-01-preview/JobExecutions.json
Expand Down Expand Up @@ -1294,6 +1293,7 @@ input-file:
- ./Microsoft.Sql/preview/2022-11-01-preview/DatabaseSqlVulnerabilityAssessmentsSettings.json
- ./Microsoft.Sql/preview/2023-02-01-preview/Servers.json
- ./Microsoft.Sql/preview/2023-02-01-preview/FailoverGroups.json
- ./Microsoft.Sql/preview/2023-05-01-preview/InstancePools.json
# Needed when there is more than one input file
Expand Down