Release 2022 02 01 preview #19820
Merged
Release 2022 02 01 preview #19820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| BackupShortTermRetentionPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| BlobAuditing.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DataWarehouseUserActivities.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseAdvancedThreatProtectionSettings.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseAdvisors.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseAutomaticTuning.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseColumns.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseExtensions.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseOperations.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseRecommendedActions.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseSchemas.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseSecurityAlertPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseTables.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseUsages.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseVulnerabilityAssessmentRuleBaselines.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseVulnerabilityAssessmentScans.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DatabaseVulnerabilityAssessments.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| Databases.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DeletedServers.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| DistributedAvailabilityGroups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ElasticPoolOperations.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ElasticPools.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| EncryptionProtectors.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| EndpointCertificates.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| FailoverGroups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| FirewallRules.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| IPv6FirewallRules.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| InstanceFailoverGroups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| InstancePools.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| JobAgents.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| JobCredentials.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| JobExecutions.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| JobStepExecutions.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| JobSteps.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| JobTargetExecutions.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| JobTargetGroups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| JobVersions.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| Jobs.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| LedgerDigestUploads.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| LocationCapabilities.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| LongTermRetentionBackups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| LongTermRetentionManagedInstanceBackups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| LongTermRetentionPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| MaintenanceWindowOptions.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| MaintenanceWindows.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedBackupShortTermRetentionPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseColumns.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseQueries.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseRestoreDetails.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseSchemas.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseSecurityAlertPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseSecurityEvents.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseSensitivityLabels.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseTables.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseTransparentDataEncryption.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseVulnerabilityAssessmentRuleBaselines.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseVulnerabilityAssessmentScans.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabaseVulnerabilityAssessments.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedDatabases.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstanceAdministrators.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstanceAzureADOnlyAuthentications.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstanceEncryptionProtectors.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstanceKeys.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstanceLongTermRetentionPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstanceOperations.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstancePrivateEndpointConnections.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstancePrivateLinkResources.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstanceTdeCertificates.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstanceVulnerabilityAssessments.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedInstances.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedRestorableDroppedDatabaseBackupShortTermRetentionPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedServerDnsAliases.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ManagedServerSecurityAlertPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| Operations.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| OutboundFirewallRules.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| PrivateEndpointConnections.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| PrivateLinkResources.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| RecoverableManagedDatabases.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ReplicationLinks.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| RestorableDroppedDatabases.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| RestorableDroppedManagedDatabases.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| RestorePoints.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| SensitivityLabels.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerAdvancedThreatProtectionSettings.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerAdvisors.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerAutomaticTuning.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerAzureADAdministrators.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerAzureADOnlyAuthentications.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerConnectionPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerDevOpsAudit.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerDnsAliases.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerKeys.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerOperations.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerSecurityAlertPolicies.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerTrustCertificates.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerTrustGroups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| ServerVulnerabilityAssessments.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| Servers.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| SqlAgent.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| SubscriptionUsages.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| SyncAgents.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| SyncGroups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| SyncMembers.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| TdeCertificates.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| TimeZones.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| TransparentDataEncryptions.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| Usages.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| VirtualClusters.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| VirtualNetworkRules.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| WorkloadClassifiers.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
| WorkloadGroups.json | 2022-02-01(6fa0e4c) | 2021-11-01(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 3 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version adds a response code '202'. New: Microsoft.Sql/preview/2022-02-01-preview/ReplicationLinks.json#L148:11 |
|
| The 'constant' status changed from the old version to the new. New: Microsoft.Sql/preview/2022-02-01-preview/ServerDevOpsAudit.json#L75:11 Old: Microsoft.Sql/preview/2021-11-01-preview/ServerDevOpsAudit.json#L75:11 |
|
| The 'constant' status changed from the old version to the new. New: Microsoft.Sql/preview/2022-02-01-preview/ServerDevOpsAudit.json#L125:11 Old: Microsoft.Sql/preview/2021-11-01-preview/ServerDevOpsAudit.json#L119:11 |
| Rule | Message |
|---|---|
| "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:ServerUsages_ListByServer;", "location":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/sql/resource-manager/Microsoft.Sql/preview/2022-02-01-preview/ServerUsages.json" |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 12 Errors, 243 Warnings failed [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-02 | package-preview-2022-02(6fa0e4c) | default(main) |
The following errors/warnings are introduced by current PR:
Only 3 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Missing identifier id in array item property Location: Microsoft.Sql/preview/2022-02-01-preview/DatabaseExtensions.json#L384 |
|
Missing identifier id in array item property Location: Microsoft.Sql/preview/2022-02-01-preview/DatabaseSqlVulnerabilityAssessmentScanResult.json#L467 |
|
Missing identifier id in array item property Location: Microsoft.Sql/preview/2022-02-01-preview/DatabaseSqlVulnerabilityAssessmentScans.json#L248 |
The following errors/warnings exist before current PR submission:
Only 3 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Sql/preview/2022-02-01-preview/LocationCapabilities.json#L1229 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Sql/preview/2022-02-01-preview/ManagedInstances.json#L805 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Sql/preview/2022-02-01-preview/ServerTrustGroups.json#L344 |
️❌Avocado: 134 Errors, 1 Warnings failed [Detail]
Only 3 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2022-02-01-preview/RecoverableDatabases.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2022-02-01-preview/ReplicationLinks.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2022-02-01-preview/ServerUsages.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SDK Track2 Validation: 4 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/6fa0e4ca6b103d4f111e926a73eb5e1fe330d823/specification/sql/resource-manager/readme.md#tag-package-preview-2022-02">sql/resource-manager/readme.md#package-preview-2022-02
Only 3 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-02", "details":"Duplicate Operation 'DatabaseSqlVulnerabilityAssessmentBaselines' > 'CreateOrUpdate' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:\n - put /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/databases/databaseName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName\n - put /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName" |
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-02", "details":"Duplicate Operation 'DatabaseSqlVulnerabilityAssessmentRuleBaselines' > 'Delete' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:\n - delete /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/databases/databaseName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName/rules/ruleId\n - delete /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName/rules/ruleId" |
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-02", "details":"Duplicate object schemas with 'SecurityAlertPolicyName' name detected." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @ericshape, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jul 19, 2022
Closed
|
@ericshape Could you fix the lint error, it's not breaking change |
addressed |
raych1
approved these changes
Jul 20, 2022
|
@ericshape will fix other lint errors in next api version. |
This was referenced Jul 20, 2022
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jul 20, 2022
24 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Due to the dev branch is hard to address the rebase conflict with the main branch in #19818 . We copy the dev branch content from
dev-sql-Microsoft.Sql-2022-02-01-previewto a new branch to complete the release.All the content in dev branch
dev-sql-Microsoft.Sql-2022-02-01-previewhas been approved by ARM reviewers.Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.