Moving missed changes from 2023-11-01 packet capture swagger fix to l… (

#29473) * Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01 * Updates readme * Updates API version in new specs and examples * Add examples for Subnet peering and v6 Subnet peering. (#28827) Add examples for Subnet peering and v6 Subnet peering. --------- Co-authored-by: saurabh83 <[email protected]> * Init (#29127) Co-authored-by: Abhishek Shah <[email protected]> * Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048) Co-authored-by: Arsheen Khatib (from Dev Box) <[email protected]> * Added NoHealthyBackendsBehavior (#28868) Added the property "NoHealthyBackendsBehavior" to the Probe properties. * VirtualNetworkGatewayConnection using key vault for authentication. (#28760) * Add parameters for cert based auth connection * retrigger checks * retrigger checks * lintDiff * Trigger Build * revert PATCH changes * fix * change managed identity to v5 * add format and description * added networkidentifier under vnet->subet->serviceendpoint (#29292) * added networkidentifier under vnet->subet->serviceendpoint * resolving conflict (#29343) * Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) * Fix * Fix2 --------- Co-authored-by: Khushboo Baheti <[email protected]> * Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) * Moving missed changes from 2023-11-01 packet capture swagger fix to latest api version * Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251) * Add CrossConnection name as an optional query parameter for List CrossConnection * update example * Addressing comments * Change to OData filtering * Fix the parameter reference * Update --------- Co-authored-by: Jianqi Zhao <[email protected]> * initial changes (#29235) * adding supression for the breaking change in azure-sdk-for-go * adding correct package for this supression --------- Co-authored-by: GuptaVertika <[email protected]> Co-authored-by: saurabh83 <[email protected]> Co-authored-by: saurabh83 <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: AFK1194 <[email protected]> Co-authored-by: Arsheen Khatib (from Dev Box) <[email protected]> Co-authored-by: Eugenio Peña García <[email protected]> Co-authored-by: daweiwang-microsoft <[email protected]> Co-authored-by: Bhupesh Kumar Bhatt <[email protected]> Co-authored-by: Khushboo Baheti <[email protected]> Co-authored-by: Khushboo Baheti <[email protected]> Co-authored-by: Ashutosh Mishra <[email protected]> Co-authored-by: jianzhao1992 <[email protected]> Co-authored-by: Jianqi Zhao <[email protected]> Co-authored-by: nimaller <[email protected]>
Azure · Jun 21, 2024 · a0ace9e · a0ace9e
1 parent 1d96e34
commit a0ace9e
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 59 deletions.
diff --git a/...ification/network/resource-manager/Microsoft.Network/stable/2024-01-01/azureFirewall.json b/...ification/network/resource-manager/Microsoft.Network/stable/2024-01-01/azureFirewall.json
@@ -1217,7 +1217,7 @@
       },
       "description": "List of SNAT IP Prefixes learnt by firewall to not SNAT"
     },
-    "FirewallPacketCaptureParametersFormat": {
+    "FirewallPacketCaptureParameters": {
       "type": "object",
       "properties": {
         "durationInSeconds": {
@@ -1267,7 +1267,7 @@
           "x-ms-identifiers": []
         }
       },
-      "description": "Packet capture parameters on azure firewall."
+      "description": "Azure Firewall Packet Capture Parameters."
     },
     "AzureFirewallPacketCaptureFlags": {
       "type": "object",
@@ -1321,22 +1321,6 @@
         }
       },
       "description": "Group of src/dest ips and ports to be captured."
-    },
-    "FirewallPacketCaptureParameters": {
-      "type": "object",
-      "properties": {
-        "properties": {
-          "x-ms-client-flatten": true,
-          "$ref": "#/definitions/FirewallPacketCaptureParametersFormat",
-          "description": "Properties of the azure firewall."
-        }
-      },
-      "allOf": [
-        {
-          "$ref": "./network.json#/definitions/SubResource"
-        }
-      ],
-      "description": "Azure Firewall Packet Capture Parameters resource."
     }
   }
 }
diff --git a/...urce-manager/Microsoft.Network/stable/2024-01-01/examples/AzureFirewallPacketCapture.json b/...urce-manager/Microsoft.Network/stable/2024-01-01/examples/AzureFirewallPacketCapture.json
@@ -5,47 +5,45 @@
     "resourceGroupName": "rg1",
     "azureFirewallName": "azureFirewall1",
     "parameters": {
-      "properties": {
-        "durationInSeconds": 300,
-        "numberOfPacketsToCapture": 5000,
-        "sasUrl": "someSASURL",
-        "fileName": "azureFirewallPacketCapture",
-        "protocol": "Any",
-        "flags": [
-          {
-            "type": "syn"
-          },
-          {
-            "type": "fin"
-          }
-        ],
-        "filters": [
-          {
-            "sources": [
-              "20.1.1.0"
-            ],
-            "destinations": [
-              "20.1.2.0"
-            ],
-            "destinationPorts": [
-              "4500"
-            ]
-          },
-          {
-            "sources": [
-              "10.1.1.0",
-              "10.1.1.1"
-            ],
-            "destinations": [
-              "10.1.2.0"
-            ],
-            "destinationPorts": [
-              "123",
-              "80"
-            ]
-          }
-        ]
-      }
+      "durationInSeconds": 300,
+      "numberOfPacketsToCapture": 5000,
+      "sasUrl": "someSASURL",
+      "fileName": "azureFirewallPacketCapture",
+      "protocol": "Any",
+      "flags": [
+        {
+          "type": "syn"
+        },
+        {
+          "type": "fin"
+        }
+      ],
+      "filters": [
+        {
+          "sources": [
+            "20.1.1.0"
+          ],
+          "destinations": [
+            "20.1.2.0"
+          ],
+          "destinationPorts": [
+            "4500"
+          ]
+        },
+        {
+          "sources": [
+            "10.1.1.0",
+            "10.1.1.1"
+          ],
+          "destinations": [
+            "10.1.2.0"
+          ],
+          "destinationPorts": [
+            "123",
+            "80"
+          ]
+        }
+      ]
     }
   },
   "responses": {

diff --git a/specification/network/resource-manager/sdk-suppressions.yaml b/specification/network/resource-manager/sdk-suppressions.yaml
@@ -0,0 +1,6 @@
+suppressions:
+  azure-sdk-for-go:
+    - package: 'sdk/resourcemanager/network/armnetwork'
+      breaking-changes:
+        - Struct `FirewallPacketCaptureParametersFormat` has been removed
+        - Field `ID`, `Properties` of struct `FirewallPacketCaptureParameters` has been removed