Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding v0 release to feed #530

Merged
merged 3 commits into from
May 16, 2024
Merged

adding v0 release to feed #530

merged 3 commits into from
May 16, 2024

Conversation

soninaren
Copy link
Member

@soninaren soninaren commented May 8, 2024 •
edited
Loading

@soninaren soninaren marked this pull request as ready for review May 11, 2024 00:32
@soninaren soninaren requested a review from a team as a code owner May 11, 2024 00:32
mattchenderson
mattchenderson requested changes May 13, 2024
View reviewed changes
GenerateToolingFeed/Helper.cs Outdated Show resolved Hide resolved
GenerateToolingFeed/V0Format/V0FormatCliEntry.cs Outdated Show resolved Hide resolved
cli-feed-v4.json Outdated Show resolved Hide resolved
cli-feed-v4.json Show resolved Hide resolved
cli-feed-v4.json Outdated Show resolved Hide resolved
cli-feed-v4.json Show resolved Hide resolved
mattchenderson
mattchenderson reviewed May 13, 2024
View reviewed changes
cli-feed-v4.json Outdated Show resolved Hide resolved
fabiocav
fabiocav reviewed May 14, 2024
View reviewed changes
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some init

GenerateToolingFeed/Helper.cs Outdated Show resolved Hide resolved
GenerateToolingFeed/Program.cs Outdated Show resolved Hide resolved
cli-feed-v4.json Outdated Show resolved Hide resolved
mattchenderson
mattchenderson reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@mattchenderson mattchenderson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending rebase/changes for mergeability. Leaving this as a comment review instead of an approval to reflect that state.

@soninaren
Copy link
Member Author

Gist from the latest rebase and update.
https://gist.github.com/soninaren/001f10032b8996e0186c8fbc12749bec/revisions#diff-de93785cb8d5c1ef09f6d63533a9c150eeb6d43ff4a0c0c05d1f707564f6f530

mattchenderson
mattchenderson reviewed May 16, 2024
View reviewed changes
cli-feed-v4.json Outdated Show resolved Hide resolved
@fabiocav fabiocav merged commit 163815c into main May 16, 2024
4 checks passed
@fabiocav fabiocav deleted the nasoni/inproc branch May 16, 2024 23:14
@soninaren soninaren mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattchenderson mattchenderson mattchenderson approved these changes

@fabiocav fabiocav fabiocav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soninaren @fabiocav @mattchenderson