Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rpcBaseUrl in durable operations when possible #1098

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

andystaples
Copy link
Contributor

Issue describing the changes in this PR

When experimenting with Azure/azure-functions-durable-powershell#73, I found that if a user does not explicitly call Import-Module on the external SDK, functions that are exposed in the external Durable SDK are not used, and instead the definitions loaded in the bundled module are used.

This change imports the fix from Azure/azure-functions-durable-powershell#66 into the bundled module, with additional checks to prevent breaking backwards compatibility.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@andystaples andystaples self-assigned this Nov 7, 2024
Copy link
Contributor

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants