[Compute] BREAKING CHANGE: Migrate commands using Code Gen V2 #30430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @yanzhudd, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| disk grant-access | cmd disk grant-access added parameter no_wait |
||
| disk grant-access | cmd disk grant-access update parameter access_level: added property aaz_default=Read |
||
| disk grant-access | cmd disk grant-access update parameter access_level: added property aaz_type=string |
||
| disk grant-access | cmd disk grant-access update parameter access_level: added property type=string |
||
| disk grant-access | cmd disk grant-access update parameter access_level: updated property choices from ['Read', 'Write'] to ['None', 'Read', 'Write'] |
||
| disk grant-access | cmd disk grant-access update parameter access_level: updated property options from ['--access-level'] to ['--access', '--access-level'] |
||
| disk grant-access | cmd disk grant-access update parameter disk_name: added property aaz_type=string |
||
| disk grant-access | cmd disk grant-access update parameter disk_name: added property type=string |
||
| disk grant-access | cmd disk grant-access update parameter disk_name: updated property options from ['--name', '-n'] to ['--disk-name', '--name', '-n'] |
||
| disk grant-access | cmd disk grant-access update parameter duration_in_seconds: added property aaz_type=int |
||
| disk grant-access | cmd disk grant-access update parameter resource_group_name: added property aaz_type=string |
||
| disk grant-access | cmd disk grant-access update parameter resource_group_name: added property type=string |
||
| disk grant-access | cmd disk grant-access update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| disk grant-access | cmd disk grant-access update parameter secure_vm_guest_state_sas: added property aaz_type=bool |
||
| disk grant-access | cmd disk grant-access update parameter secure_vm_guest_state_sas: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk grant-access | cmd disk grant-access update parameter secure_vm_guest_state_sas: added property nargs=? |
||
| disk grant-access | cmd disk grant-access update parameter secure_vm_guest_state_sas: added property type=bool |
||
| disk update | cmd disk update update parameter accelerated_network: added property aaz_type=bool |
||
| disk update | cmd disk update update parameter accelerated_network: added property type=bool |
||
| disk update | cmd disk update update parameter accelerated_network: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk update | cmd disk update update parameter architecture: added property aaz_type=string |
||
| disk update | cmd disk update update parameter architecture: added property type=string |
||
| disk update | cmd disk update update parameter data_access_auth_mode: added property aaz_type=string |
||
| disk update | cmd disk update update parameter data_access_auth_mode: added property type=string |
||
| disk update | cmd disk update update parameter disk_access: added property aaz_type=string |
||
| disk update | cmd disk update update parameter disk_access: added property type=string |
||
| disk update | cmd disk update update parameter disk_encryption_set: added property aaz_type=string |
||
| disk update | cmd disk update update parameter disk_encryption_set: added property type=string |
||
| disk update | cmd disk update update parameter disk_iops_read_only: added property aaz_type=int |
||
| disk update | cmd disk update update parameter disk_iops_read_write: added property aaz_type=int |
||
| disk update | cmd disk update update parameter disk_mbps_read_only: added property aaz_type=int |
||
| disk update | cmd disk update update parameter disk_mbps_read_write: added property aaz_type=int |
||
| disk update | cmd disk update update parameter disk_name: added property aaz_type=string |
||
| disk update | cmd disk update update parameter disk_name: added property type=string |
||
| disk update | cmd disk update update parameter disk_name: updated property options from ['--name', '-n'] to ['--disk-name', '--name', '-n'] |
||
| disk update | cmd disk update update parameter enable_bursting: added property aaz_type=bool |
||
| disk update | cmd disk update update parameter enable_bursting: added property type=bool |
||
| disk update | cmd disk update update parameter enable_bursting: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk update | cmd disk update update parameter enable_bursting: updated property name from enable_bursting to bursting_enabled |
||
| disk update | cmd disk update update parameter enable_bursting: updated property options from ['--enable-bursting'] to ['--bursting-enabled', '--enable-bursting'] |
||
| disk update | cmd disk update update parameter encryption_type: added property aaz_type=string |
||
| disk update | cmd disk update update parameter encryption_type: added property type=string |
||
| disk update | cmd disk update update parameter max_shares: added property aaz_type=int |
||
| disk update | cmd disk update update parameter network_access_policy: added property aaz_type=string |
||
| disk update | cmd disk update update parameter network_access_policy: added property type=string |
||
| disk update | cmd disk update update parameter no_wait: added property aaz_type=bool |
||
| disk update | cmd disk update update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk update | cmd disk update update parameter no_wait: added property nargs=? |
||
| disk update | cmd disk update update parameter no_wait: added property type=bool |
||
| disk update | cmd disk update update parameter properties_to_add: added property aaz_type=AAZGenericUpdateAddArg |
||
| disk update | cmd disk update update parameter properties_to_remove: added property aaz_type=AAZGenericUpdateRemoveArg |
||
| disk update | cmd disk update update parameter properties_to_set: added property aaz_type=AAZGenericUpdateSetArg |
||
| disk update | cmd disk update update parameter public_network_access: added property aaz_type=string |
||
| disk update | cmd disk update update parameter public_network_access: added property type=string |
||
| disk update | cmd disk update update parameter resource_group_name: added property aaz_type=string |
||
| disk update | cmd disk update update parameter resource_group_name: added property type=string |
||
| disk update | cmd disk update update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| disk update | cmd disk update update parameter size_gb: added property aaz_type=int |
||
| disk update | cmd disk update update parameter size_gb: updated property name from size_gb to disk_size_gb |
||
| disk update | cmd disk update update parameter size_gb: updated property options from ['--size-gb', '-z'] to ['--disk-size-gb', '--size-gb', '-z'] |
||
| disk update | cmd disk update update parameter sku: added property aaz_type=string |
||
| disk update | cmd disk update update parameter sku: added property type=string |
||
| image update | cmd image update added parameter no_wait |
||
| image update | cmd image update update parameter image_name: added property aaz_type=string |
||
| image update | cmd image update update parameter image_name: added property type=string |
||
| image update | cmd image update update parameter image_name: updated property options from ['--name', '-n'] to ['--image-name', '--name', '-n'] |
||
| image update | cmd image update update parameter properties_to_add: added property aaz_type=AAZGenericUpdateAddArg |
||
| image update | cmd image update update parameter properties_to_remove: added property aaz_type=AAZGenericUpdateRemoveArg |
||
| image update | cmd image update update parameter properties_to_set: added property aaz_type=AAZGenericUpdateSetArg |
||
| image update | cmd image update update parameter resource_group_name: added property aaz_type=string |
||
| image update | cmd image update update parameter resource_group_name: added property type=string |
||
| image update | cmd image update update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| image update | cmd image update update parameter tags: added property aaz_type=AAZDictArg |
||
| image update | cmd image update update parameter tags: added property type=Dict<String,String> |
||
| image update | cmd image update update parameter tags: updated property nargs from * to + |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
the
Compute
…-image-command
zhoxing-ms
reviewed
Dec 3, 2024
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/disk/__cmd_group.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Dec 3, 2024
src/azure-cli/azure/cli/command_modules/vm/aaz/profile_2018_03_01_hybrid/disk/__cmd_group.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Dec 3, 2024
src/azure-cli/azure/cli/command_modules/vm/aaz/profile_2019_03_01_hybrid/disk/__cmd_group.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Dec 3, 2024
src/azure-cli/azure/cli/command_modules/vm/aaz/profile_2018_03_01_hybrid/image/_show.py
Show resolved
Hide resolved
zhoxing-ms
reviewed
Dec 3, 2024
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py
Show resolved
Hide resolved
zhoxing-ms
changed the title
zhoxing-ms
approved these changes
Dec 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az disk create/update/grant-accessaz image create/updateDescription
Migrate
diskandimagecommand group to Code Gen V2Note: The subcommand groups have not yet been migrated
AAZ PR: Azure/aaz#640
Testing Guide
History Notes
[Compute] BREAKING CHANGE:
az disk: Refine output fields to align with backend serviceThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.