Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export az afd api with aaz #338

Closed
wants to merge 0 commits into from
Closed

Export az afd api with aaz #338

wants to merge 0 commits into from

Conversation

Ptnan7
Copy link
Member

@Ptnan7 Ptnan7 commented Nov 9, 2023

No description provided.

@kairu-ms
Copy link
Collaborator

@Ptnan7 Could you add link of any PR in azure-cli or azure-cli-extensions?

@kairu-ms kairu-ms requested a review from necusjz December 11, 2023 02:40
@kairu-ms
Copy link
Collaborator

Azure/azure-cli#27807

@necusjz
Copy link
Member

necusjz commented Dec 11, 2023

Seems all the afd commands should be in preview not "Stable" https://github.com/Azure/azure-cli/blob/71d478f3df9dbc6fe8583baf9308a7597450011f/src/azure-cli/azure/cli/command_modules/cdn/commands.py#L289.

necusjz
necusjz requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@necusjz necusjz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the current PR is not "clean" enough, please pull the latest <main> branch, and <Export> your command model again.

@Ptnan7 Ptnan7 closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necusjz necusjz necusjz requested changes

Assignees

@necusjz necusjz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ptnan7 @kairu-ms @necusjz