Add basic response for lro delete operation in typespec-aaz #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllyW
changed the title
AllyW
changed the title
kairu-ms
reviewed
Dec 16, 2024
Comment on lines
+395
to
+399
| const lro_response: CMDHttpResponse = { | ||
| statusCode: [200, 201], | ||
| isError: false, | ||
| description: "Response schema for long-running operation." | ||
| }; |
There was a problem hiding this comment.
What's the schema of LRO for delete of 200 and 201 response? You can verify what 200 and 201 responses are used in LRO based on azure rest api guideline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to swagger codegen pr: #333
ref:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/delete-response-codes.md#output-message
https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/openapi-authoring-automated-guidelines.md#r2064-lrostatuscodesreturntypeschema
https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-long-running-operation-options