Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/adding first contrib #3188

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

that-ar-guy
Copy link
Contributor

PR Summary

fixes : #3097
Added a new file first-contributors-guide.md in docs/license-contributing/ for guiding new contributors so that they can easily onboard to the project and start contributing.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @that-ar-guy for your PR. Great start. I've added some suggestions.

Also you can add a link to the table of contents here (

- Index: license-contributing/index.md
) below index so that it will appear in the docs.

docs/license-contributing/first-contributors-guide.md Outdated Show resolved Hide resolved
docs/license-contributing/first-contributors-guide.md Outdated Show resolved Hide resolved
docs/license-contributing/first-contributors-guide.md Outdated Show resolved Hide resolved
docs/license-contributing/first-contributors-guide.md Outdated Show resolved Hide resolved
@that-ar-guy
Copy link
Contributor Author

@BernieWhite , I've incorporated the requested changes. Please review the updates.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @that-ar-guy. I've added some additional changes to your PR.

Have a look at let me know if you are happy with these changes.

@that-ar-guy
Copy link
Contributor Author

@microsoft-github-policy-service agree

@that-ar-guy
Copy link
Contributor Author

Thanks, @BernieWhite , for the updates! I've reviewed the additional changes, and they look great to me. I'm happy with these edits.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @that-ar-guy. All good to merge.

@BernieWhite BernieWhite merged commit 56ac434 into Azure:main Dec 4, 2024
13 checks passed
@that-ar-guy that-ar-guy deleted the docs/adding-first-contrib branch December 5, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add walk through for first time contributors
2 participants