Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated Azure.APIM.AvailabilityZone #2874

Merged
merged 2 commits into from
May 21, 2024
Merged

feat: Updated Azure.APIM.AvailabilityZone #2874

merged 2 commits into from
May 21, 2024

Conversation

BenjaminEngeset
Copy link
Contributor

PR Summary

Fixes #2788

Updated Azure.APIM.AvailabilityZone.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BenjaminEngeset BenjaminEngeset requested a review from a team as a code owner May 20, 2024 07:21
@BenjaminEngeset
Copy link
Contributor Author

Ready for review @BernieWhite. I would appreciate your feedback on it.

BernieWhite
BernieWhite requested changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminEngeset. Great work. Please see my suggestions below.

docs/CHANGELOG-v1.md Outdated Show resolved Hide resolved
docs/en/rules/Azure.APIM.AvailabilityZone.md Outdated Show resolved Hide resolved
src/PSRule.Rules.Azure/rules/Azure.APIM.Rule.ps1 Outdated Show resolved Hide resolved
docs/en/rules/Azure.APIM.AvailabilityZone.md Outdated Show resolved Hide resolved
docs/en/rules/Azure.APIM.AvailabilityZone.md Outdated Show resolved Hide resolved
@BenjaminEngeset
Copy link
Contributor Author

I think we should be all set, @BernieWhite. Please check the latest updates.

BernieWhite
BernieWhite approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @BenjaminEngeset. All good to merge.

@BernieWhite BernieWhite merged commit 00e1ca9 into Azure:main May 21, 2024
13 checks passed
@BenjaminEngeset BenjaminEngeset mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernieWhite BernieWhite BernieWhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add rule for APIM to check capacity is set to same or more than number of zones deployed too
2 participants
@BenjaminEngeset @BernieWhite