Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new): Added Azure.APIM.AvailabilityZone.Units #2866

Conversation

BenjaminEngeset
Copy link
Contributor

PR Summary

Fixes #2788

Added Azure.APIM.AvailabilityZone.Units.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BenjaminEngeset BenjaminEngeset requested a review from a team as a code owner May 14, 2024 15:56
@BenjaminEngeset
Copy link
Contributor Author

Hi @BernieWhite. Let me know your thoughts on this one.

@BenjaminEngeset
Copy link
Contributor Author

BenjaminEngeset commented May 15, 2024

@BernieWhite I'd also like to know what to do with the tests. With the scenarios I have added I'm causing a lot of change for the other tests already created and implemented. I can update them, but want to know before doing so, as it is some effort.

@BernieWhite
Copy link
Collaborator

@BenjaminEngeset Thanks for your efforts so far. I think there is duplication with Azure.APIM.AvailabilityZone. Let's park this until we confirm with Jack if there is any changes required to the existing rule.

@BenjaminEngeset
Copy link
Contributor Author

As discussed in #2788, let's close this PR and I will instead a create a new one with what we have aligned on.

@BenjaminEngeset BenjaminEngeset deleted the users/benjaminengeset/apim-units-across-availability-zones branch May 19, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add rule for APIM to check capacity is set to same or more than number of zones deployed too
2 participants