Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(new): Added Azure.Cosmos.PublicAccess #2863

Merged
merged 1 commit into from
May 11, 2024
Merged

feat(new): Added Azure.Cosmos.PublicAccess #2863

merged 1 commit into from
May 11, 2024

Conversation

BenjaminEngeset
Copy link
Contributor

PR Summary

Fixes #2702

Added Azure.Cosmos.PublicAccess.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BenjaminEngeset BenjaminEngeset requested a review from a team as a code owner May 9, 2024 18:03
@BenjaminEngeset
Copy link
Contributor Author

Ready for review @BernieWhite.

BernieWhite
BernieWhite approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminEngeset. All good to merge.

@BernieWhite BernieWhite merged commit 616f8e8 into Azure:main May 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernieWhite BernieWhite BernieWhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RULE] Disable cosmos account public access
2 participants
@BenjaminEngeset @BernieWhite