Handle key collision with duplicate definitions using same parameters

[ArmaanMcleod]

PR Summary

Related to #1653.

Fixes key collisions with definitions using same parameters.
Also refactored a bit of csharp code.

PR Checklist

• PR has a meaningful title
• Summarized changes
• Change is not breaking
• This PR is ready to merge and is not Work in Progress
• Rule changes
  • Unit tests created/ updated
  • Rule documentation created/ updated
  • Link to a filed issue
  • Change log has been updated with change under unreleased section
• Other code changes
  • Unit tests created/ updated
  • Link to a filed issue
  • Change log has been updated with change under unreleased section

[ghost]

All CLA requirements met.

[ArmaanMcleod]

@BernieWhite Made some changes to only store definition parameters, let me know what you think.

[BernieWhite]

@ArmaanMcleod Nice work. I think functionally let's go with this. I think we can optimize this further over the next few releases, however I don't think we need to invest that time now as the code based is rapidly changing.

Let's fix these id's and after that we should be good to merge.

[ArmaanMcleod]

@ArmaanMcleod Nice work. I think functionally let's go with this. I think we can optimize this further over the next few releases, however I don't think we need to invest that time now as the code based is rapidly changing.

Let's fix these id's and after that we should be good to merge.

@BernieWhite Thanks mate, all good to keep iterating on this in the next few releases. Next, I can probably add the name and ref properties.

I've updated the code with your suggestions 🙂.

There also seem to be some pending workflow approvals that are needed for first-time contributors, probably has to be done again after I signed the CLA again 😄.

[BernieWhite]

Thanks @ArmaanMcleod all good to merge.