Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(designer): Scope actions E2E tests #6421

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Jan 17, 2025

This pull request includes several changes to improve the testing and functionality of the scope actions and node collapse toggles in the VS Code Designer application. The most important changes include the removal of an unused utility function, the addition of new tests for asset utilities, and the enhancement of the node collapse toggle components.

Removal of Unused Code:

  • Removed the getCoreNodeModule function as it was no longer being used.

Addition of New Tests:

  • Added new tests for the getIconPath and getThemedIconPath functions using the vitest framework.

Enhancements to Node Collapse Toggles:

  • Added id prop to the NodeCollapseToggle component to improve testability and accessibility.
  • Added id prop to the NodeCollapseToggle component for better identification and testing.
  • Updated the NodeCollapseToggle component to accept an id prop and use it for data automation IDs.

Improvements to Scope and Subgraph Cards:

  • Added data automation IDs to the "no actions" text for better testing and identification.
  • Added data automation IDs to the "no actions" text for improved testability.

Addition of New E2E Tests:

  • Added new end-to-end tests for collapsing and expanding scope actions, including conditions, foreach, do until, and switch actions.

@ccastrotrejo ccastrotrejo requested a review from Copilot January 17, 2025 18:41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • apps/vs-code-designer/src/app/utils/getCoreNodeModule.ts: Evaluated as low risk
  • e2e/designer/scopeActions.spec.ts: Evaluated as low risk
  • libs/designer-ui/src/lib/card/scopeCard/index.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)

libs/designer/src/lib/ui/CustomNodes/SubgraphCardNode.tsx:168

  • [nitpick] The error message collapsedText is unclear and may not provide enough context for the user. Consider providing a more descriptive message.
{collapsedText}
@ccastrotrejo ccastrotrejo merged commit a40fe8a into main Jan 17, 2025
13 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/Tests branch January 17, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants