-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs #248
Docs #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 7 comments.
Files not reviewed (1)
- scripts/test_ie.sh: Language not supported
Comments suppressed due to low confidence (2)
docs/README.md:17
- The phrase 'customer Portal interface' should be 'custom Portal interface'.
Innovation Engine is designed to be reused in custom user experiences. For example, Microsoft Azure uses Innovation Engine to provide documentation on their Learn site, which can also be executed in the Azure Portal. This allows users to explore 'good practice' documentation at the pace they prefer. They can simply read the documentation, they can interactively work through it in a customer Portal interface or they can simply go ahead and run it in order to deploy the architecture described within the document.
README.md:36
- Typo ('excercise' should be 'exercise'). Suggestion: 'As an exercise, if you have checked out the Innovation Engine code you could edit the echo statement above, whilst not updating the results block.'
As an excercise, if you have checked out the Innovation Engine code you could edit the echo statement above, whilst not updating the results block.
Innovation Engine is a tool for rapid innovation and simplification. Innovation Engine is | ||
a CLI tool known as ie that enables execution and testing of Executable Documentation. | ||
|
||
Executable Documentation is a shell script, leveraging any tools available in the shell and embedding it within documentation. That is, it takes standard markdown language and amplifies it by allowing the code commands within the document to be executed interacted with an executed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'executed interacted with an executed' is incorrect. It should be revised for clarity.
Executable Documentation is a shell script, leveraging any tools available in the shell and embedding it within documentation. That is, it takes standard markdown language and amplifies it by allowing the code commands within the document to be executed interacted with an executed. | |
Executable Documentation is a shell script, leveraging any tools available in the shell and embedding it within documentation. That is, it takes standard markdown language and amplifies it by allowing the code commands within the document to be executed and interacted with. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
||
Using Innovation Engine you can: | ||
|
||
* Describe the intent and expected behaviour of your shell scripts in markdown rather than comments. This means you documentation can contain hyperlinks, images, formatting etc. It can be rendered as standard markdown, e.g. as a `README.md` or a wiki page in GitHub, or as a web page. It also means that there is no need to keep two separate documents in sync. Editing code and documentation is now done in a single file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'you documentation' should be 'your documentation'.
* Describe the intent and expected behaviour of your shell scripts in markdown rather than comments. This means you documentation can contain hyperlinks, images, formatting etc. It can be rendered as standard markdown, e.g. as a `README.md` or a wiki page in GitHub, or as a web page. It also means that there is no need to keep two separate documents in sync. Editing code and documentation is now done in a single file. | |
* Describe the intent and expected behaviour of your shell scripts in markdown rather than comments. This means your documentation can contain hyperlinks, images, formatting etc. It can be rendered as standard markdown, e.g. as a `README.md` or a wiki page in GitHub, or as a web page. It also means that there is no need to keep two separate documents in sync. Editing code and documentation is now done in a single file. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
||
There are multiple ways of testing the output against the actual results. Here we are saying the output should be identical to the example text (a 100%, or 1.0, match in this case). We'll cover other ways of validating the results in subsequent content. | ||
|
||
As an excercise, if you have checked out the Innovation Engine code you could edit the echo statement above, whilst not updating the results block. When you run `ie test scripts/README.md` this code will then fail. Not very useful, but a good first example of how you can improve the quality of your documentation and scripts through testing with Innovation Engine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'excercise' is misspelled. It should be 'exercise'.
As an excercise, if you have checked out the Innovation Engine code you could edit the echo statement above, whilst not updating the results block. When you run `ie test scripts/README.md` this code will then fail. Not very useful, but a good first example of how you can improve the quality of your documentation and scripts through testing with Innovation Engine. | |
As an exercise, if you have checked out the Innovation Engine code you could edit the echo statement above, whilst not updating the results block. When you run `ie test scripts/README.md` this code will then fail. Not very useful, but a good first example of how you can improve the quality of your documentation and scripts through testing with Innovation Engine. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Executable documentation takes standard markdown language and amplifies it by | ||
allowing the code commands within the document to be executed in full or step by step in an educational manner, and tested | ||
via automated CI/CD pipelines. | ||
Executable Documentation is a shell script, leveraging any tools available in the shell and embedding it within documentation. That is, it takes standard markdown language and amplifies it by allowing the code commands within the document to be executed interacted with an executed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar error. Suggestion: 'allowing the code commands within the document to be executed and interacted with.'
Executable Documentation is a shell script, leveraging any tools available in the shell and embedding it within documentation. That is, it takes standard markdown language and amplifies it by allowing the code commands within the document to be executed interacted with an executed. | |
Executable Documentation is a shell script, leveraging any tools available in the shell and embedding it within documentation. That is, it takes standard markdown language and amplifies it by allowing the code commands within the document to be executed and interacted with. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
||
Using Innovation Engine you can: | ||
|
||
* Describe the intent and expected behaviour of your shell scripts in markdown rather than comments. This means you documentation can contain hyperlinks, images, formatting etc. It can be rendered as standard markdown, e.g. as a `README.md` or a wiki page in GitHub, or as a web page. It also means that there is no need to keep two separate documents in sync. Editing code and documentation is now done in a single file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo ('you' should be 'your'). Suggestion: 'This means your documentation can contain hyperlinks, images, formatting etc.'
* Describe the intent and expected behaviour of your shell scripts in markdown rather than comments. This means you documentation can contain hyperlinks, images, formatting etc. It can be rendered as standard markdown, e.g. as a `README.md` or a wiki page in GitHub, or as a web page. It also means that there is no need to keep two separate documents in sync. Editing code and documentation is now done in a single file. | |
* Describe the intent and expected behaviour of your shell scripts in markdown rather than comments. This means your documentation can contain hyperlinks, images, formatting etc. It can be rendered as standard markdown, e.g. as a `README.md` or a wiki page in GitHub, or as a web page. It also means that there is no need to keep two separate documents in sync. Editing code and documentation is now done in a single file. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
@@ -40,6 +50,14 @@ command: | |||
./bin/ie execute tutorial.md | |||
``` | |||
|
|||
## Testing Innovation Engine | |||
|
|||
Innovation Engine is self-documenting, that is all our documentation is written to be executable. Since Innovation Engine can test the actual results of an execution against the intended reslts this means our documentation is also part of our test suite. In our `scripts` folder you will find a `test_ie.sh` script. Running this will run through all of our documentation in test mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo ('reslts' should be 'results'). Suggestion: 'Since Innovation Engine can test the actual results of an execution against the intended results, this means our documentation is also part of our test suite.'
Innovation Engine is self-documenting, that is all our documentation is written to be executable. Since Innovation Engine can test the actual results of an execution against the intended reslts this means our documentation is also part of our test suite. In our `scripts` folder you will find a `test_ie.sh` script. Running this will run through all of our documentation in test mode. | |
Innovation Engine is self-documenting, that is all our documentation is written to be executable. Since Innovation Engine can test the actual results of an execution against the intended results, this means our documentation is also part of our test suite. In our `scripts` folder you will find a `test_ie.sh` script. Running this will run through all of our documentation in test mode. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
||
Innovation Engine is self-documenting, that is all our documentation is written to be executable. Since Innovation Engine can test the actual results of an execution against the intended reslts this means our documentation is also part of our test suite. In our `scripts` folder you will find a `test_ie.sh` script. Running this will run through all of our documentation in test mode. | ||
|
||
If you make any changes to the IE code (see Contributing below) we would encourage you to tun the full test suite before issuing a PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo ('tun' should be 'run'). Suggestion: 'we would encourage you to run the full test suite before issuing a PR.'
If you make any changes to the IE code (see Contributing below) we would encourage you to tun the full test suite before issuing a PR. | |
If you make any changes to the IE code (see Contributing below) we would encourage you to run the full test suite before issuing a PR. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
No description provided.