-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encrypt transit update #1865
Draft
cassiekays
wants to merge
8
commits into
Azure:policy-refresh-q2fy25
Choose a base branch
from
cassiekays:encryptTransit_update
base: policy-refresh-q2fy25
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Encrypt transit update #1865
cassiekays
wants to merge
8
commits into
Azure:policy-refresh-q2fy25
from
cassiekays:encryptTransit_update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on; add supersededBy reference
Springstone
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the comments, also please add an entry in the WhatsNew.md under Policy Refresh Q2FY25 describing the deprecation (you can search for the previous entry and do something similar).
Also, please update the initiative assignment to point to the updated file.
src/resources/Microsoft.Authorization/policySetDefinitions/Enforce-EncryptTransit_20240509.json
Outdated
Show resolved
Hide resolved
src/resources/Microsoft.Authorization/policySetDefinitions/Enforce-EncryptTransit_20241211.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request includes several updates to the deprecation and replacement of various Azure policy definitions and templates. The most important changes involve the deprecation of older policies and the introduction of new or updated policies to address breaking changes or improve functionality.
Deprecation and Replacement of Policies:
docs/wiki/ALZ-Deprecated-Services.md
: Updated the deprecation information for multiple policies, includingDeploy-Sql-vulnerabilityAssessments
,Deploy-MDFC-Config
,Enforce-EncryptTransit
, and others, with new replacement policies.src/resources/Microsoft.Authorization/policySetDefinitions/Enforce-EncryptTransit_20240509.json
: Marked theEnforce-EncryptTransit_20240509
policy as deprecated and provided a link to the newEnforce-EncryptTransit_20241211
policy.Template and Metadata Updates:
eslzArm/managementGroupTemplates/roleDefinitions/customRoleDefinitions.json
: Updated thebicep
template generator version and template hash to reflect the latest changes.src/templates/initiatives.bicep
: Added the newEnforce-EncryptTransit_20241211.json
policy to the list of loaded policy set definitions.Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Testing URLs
The below URLs can be updated where the placeholders are, look for
{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}
&{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}
, to allow you to test your portal deployment experience.Azure Public
[](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Feslz-portal.json)
Azure US Gov (Fairfax)
[](https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Ffairfaxeslz-portal.json)
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)