Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: casing in set params #1701

Merged
merged 2 commits into from
Jul 4, 2024
Merged

fix: casing in set params #1701

merged 2 commits into from
Jul 4, 2024

Conversation

matt-FFFFFF
Copy link
Member

Minor case fix as new Terraform provider is case sensitive about these things.

Issue was that the parameter name did not exactly match the referenced built-in name.

@matt-FFFFFF matt-FFFFFF requested a review from Springstone July 3, 2024 17:33
@matt-FFFFFF
Copy link
Member Author

matt-FFFFFF commented Jul 3, 2024

Hi @Springstone this is a very minor one that won't affect ARM at all, but will make TF happy - can you take a quick look please?

ta

@matt-FFFFFF matt-FFFFFF added the Area: Policy 📝 Issues / PR's related to Policy label Jul 3, 2024
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - now issues with case adjustments

@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Jul 3, 2024
@Springstone Springstone closed this Jul 3, 2024
@Springstone Springstone reopened this Jul 3, 2024
@jtracey93 jtracey93 closed this Jul 4, 2024
@jtracey93 jtracey93 reopened this Jul 4, 2024
@jtracey93 jtracey93 merged commit 66b79d1 into main Jul 4, 2024
5 of 9 checks passed
@jtracey93 jtracey93 deleted the fix/casingInSetParams branch July 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants