Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deploy-MDFC-Config_20240319 to use the newer defender for CSPM initiative: 72f8cee7-2937-403d-84a1-a4e3e57f3c21 #1682

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

JonasCordsen
Copy link
Contributor

@JonasCordsen JonasCordsen commented Jun 17, 2024

… initiative: 72f8cee7-2937-403d-84a1-a4e3e57f3c21

Overview/Summary

This PR will replace the policy for enabling and configuring the MDFC configuration via policies
Initiative: Deploy-MDFC-Config_20240319
Policy to be replaced: Configure Microsoft Defender CSPM to be enabled
New policy as a replacement Configure Microsoft Defender CSPM plan

This PR fixes/adds/changes/removes

  1. Adds the more settings for MDFC with the new policy added to the initiative [Policy]: Update of Configure Microsoft Defender CSPM to be enabled to newer built-in policy #1680

Breaking Changes

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@JonasCordsen
Copy link
Contributor Author

@microsoft-github-policy-service agree

@JonasCordsen JonasCordsen marked this pull request as ready for review June 17, 2024 13:58
@JonasCordsen JonasCordsen requested a review from a team as a code owner June 17, 2024 13:58
@jtracey93 jtracey93 added Area: MDFC 🔒 Issues / PR's related to Microsoft Defender for Cloud Area: Policy 📝 Issues / PR's related to Policy labels Jun 18, 2024
@jtracey93
Copy link
Collaborator

Thanks @JonasCordsen, I will get @Springstone to look at this when he returns next week 👍

@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Jun 25, 2024
Springstone

This comment was marked as outdated.

Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect, one minor change please. Can you please increment the PolicySet major version as per this guidance: https://github.com/Azure/Enterprise-Scale/wiki/ALZ-Policies#versioning

@JonasCordsen
Copy link
Contributor Author

Almost perfect, one minor change please. Can you please increment the PolicySet major version as per this guidance: https://github.com/Azure/Enterprise-Scale/wiki/ALZ-Policies#versioning

This has been updated to 2.0.0

Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93
Copy link
Collaborator

@Springstone did you confirm this is not a breaking change? And this can be upgraded in place without having to remove any assignments of the policy initiative first?

@Springstone
Copy link
Member

@Springstone did you confirm this is not a breaking change? And this can be upgraded in place without having to remove any assignments of the policy initiative first?

@jtracey93 Yes, confirmed and tested. It updates the existing initiative and assignment with the new built-in. No re-assignment necessary.

@Springstone Springstone changed the base branch from main to policy-refresh-q1fy25 July 2, 2024 09:46
@Springstone
Copy link
Member

@JonasCordsen many thanks for your contribution. Just FYI, I've retargeted your PR to the policy-refresh-q1fy25 branch, which helps our downstream users tackle all changes at once.

@Springstone Springstone merged commit a15b193 into Azure:policy-refresh-q1fy25 Jul 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: MDFC 🔒 Issues / PR's related to Microsoft Defender for Cloud Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants