Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH 1423 - Policy PaaS should Disable Public Access for Container Apps #1447

Merged
merged 13 commits into from
Oct 27, 2023
Merged

Conversation

4pplied
Copy link
Contributor

@4pplied 4pplied commented Oct 12, 2023

Overview/Summary

PR to fix Issue #1423
Adds two new policy definitions to two initiatives to cover this off.

AB#30888

This PR fixes/adds/changes/removes

Breaking Changes

  1. N/A

Testing Evidence

image

image

Testing URLs

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone changed the title GH 1423 - Policy PaaS should Disable Public Access GH 1423 - Policy PaaS should Disable Public Access for Container Apps Oct 12, 2023
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the PR details with the same clarification on exactly what is changing. Kindly also provide testing evidence and convert from Draft for merge consideration.

docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
@jtracey93 jtracey93 added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Oct 23, 2023
@jtracey93 jtracey93 closed this Oct 23, 2023
@jtracey93 jtracey93 reopened this Oct 23, 2023
@4pplied 4pplied marked this pull request as ready for review October 23, 2023 18:24
@4pplied 4pplied requested a review from a team as a code owner October 23, 2023 18:24
@4pplied
Copy link
Contributor Author

4pplied commented Oct 23, 2023

@Springstone this is ready for review again please.

Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could please address the ask, much appreciated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment initiative version.

@Springstone Springstone merged commit af761ad into Azure:policy-refresh-q2fy24 Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants