Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include AMBA policies in portal accelerator #1414

Merged
merged 90 commits into from
Oct 4, 2023

Conversation

jfaurskov
Copy link
Contributor

@jfaurskov jfaurskov commented Sep 1, 2023

Overview/Summary

Add the AMBA-ALZ baselines to the portal accelerator experience. Tracking ADO item is 22592.

This PR fixes/adds/changes/removes

  1. Update eslzArm/eslz-portal.json to include monitoring baselines as a separate pane in the portal accelerator experience.
  2. Update eslzArm/eslzArm.json to include monitoring baselines based on external alzam.json file in AMBA repo.
  3. Update documentation reference new steps to take place including updated screenshots
  4. Update requirements section in readmes to reflect that requirements are specified elsewhere
  5. Update docs/wiki/ALZ-Policies.md to inlude reference to policies on AMBA repo
  6. Update deployment documentation for different deployment scenarios (contoso, wingtip etc..)
  7. Update docs/wiki/Deploying-ALZ-CustomerUsage.md with link to AMBA-ALZ telemetry documentation

Breaking Changes

  1. AMBA-ALZ policies are introduced as part of the portal accelerator deployment

Testing Evidence

Portal accelerator experience:
image

image

Deployment:

image

Policy deployment:

image

image

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

[Deploy To Azure](https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Ffairfaxeslz-portal.json)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Co-authored-by: Jack Tracey <[email protected]>
Co-authored-by: Jack Tracey <[email protected]>
@jfaurskov jfaurskov temporarily deployed to csu-rw October 3, 2023 08:39 — with GitHub Actions Inactive
@jfaurskov jfaurskov temporarily deployed to csu-rw October 3, 2023 13:30 — with GitHub Actions Inactive
@jfaurskov jfaurskov temporarily deployed to csu-rw October 4, 2023 18:57 — with GitHub Actions Inactive
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit f9facfd into Azure:main Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants