Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bastion: updated API and added features #396

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Conversation

aporodnov
Copy link
Contributor

Overview/Summary

Updated the APIs for the Azure Bastion Hosts to support new features.
Added available features to the Bastion Host resource, so this module can be reused by landing zones that would like to utilize new bastion features.

This PR fixes/adds/changes/removes

Changes the bastion.bicep file that is used as a module by some landing zones archetypes.

Breaking Changes

N/A

Testing Evidence

I have tested it with the "standard" SKU deployment. I build in the default values for each feature, but have not tested the deployment with Developer or Basic SKUs.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 21, 2024
@tredell tredell removed the stale label May 22, 2024
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 21, 2024
@github-actions github-actions bot closed this Aug 28, 2024
@tredell tredell reopened this Nov 7, 2024
@tredell tredell requested a review from Vallentyne as a code owner November 7, 2024 16:46
Copy link
Contributor

@tredell tredell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are non-breaking

Copy link
Contributor

@tredell tredell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve the Schema validation issues.

@Vallentyne Vallentyne merged commit 4fb3c81 into main Nov 7, 2024
2 checks passed
@Vallentyne Vallentyne deleted the aporodnov-bastion branch November 7, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants