-
Notifications
You must be signed in to change notification settings - Fork 133
US 32392 Fix Queries for AFD 1 AFD 10 and AFD 11 #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @didayal-msft. Please include screenshots of your test results for each query.
@ejhenry Updated original post with screenshots |
@Azure/aprl-networking please review and compare with #318 |
@Azure/aprl-networking please review |
Hey @didayal-msft, just checking as I see this PR is in a draft state, are you going to be adding stuff or can you set the PR ready to review if applicable. |
@oZakari sorry left it in draft. No changes and this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@didayal-msft really nice work on these queries. I've just updated the summary table for the new queries but LGTM
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
Related Issues/Work Items
AB#32392 Azure Front Door - APRL ARG Query Quality Improvement
This PR fixes/adds/changes/removes
AFD-1 - Avoid combining Traffic Manager and Front Door
This query lists out all traffic manager profiles where endpoint target value is equal to the azure front door endpoint name or azure front door custom domain name.
This works on the premise that traffic manager and front door can only be combined if traffic manager endpoint type is "external" (azure endpoint and nested endpoint being the other 2) and value is equal to AFD endpoint or custom domain.
If this is not the right premise, please help me with a pattern on how TM and AFD can be combined, and I will correlate using ARG.
AFD-10 - Enable the WAF
The query shows AFDs with no security policies or where there are no managed rules (which will automatically include standard skus).
AFD-11 - Disable health probes when there is only one origin in an origin group
Query shows AFDs with single origin and active health probe.
As part of this Pull Request I have
main
branch