Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update be448849-0d7d-49ba-9c94-9573ee533d5d.kql #571

Closed
wants to merge 6 commits into from
Closed

fix: Update be448849-0d7d-49ba-9c94-9573ee533d5d.kql #571

wants to merge 6 commits into from

Conversation

Claudio-Merola
Copy link
Contributor

@Claudio-Merola Claudio-Merola commented Dec 12, 2024 •
edited
Loading

Overview/Summary

ARG Query for the recommendation: be448849-0d7d-49ba-9c94-9573ee533d5d

"Configure Resource Health Alerts"

Also move the recommendation to the resource type "Microsoft.Subscription/Subscriptions"

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Claudio-Merola Claudio-Merola requested a review from a team as a code owner December 12, 2024 21:04
rodrigosantosms
rodrigosantosms requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@rodrigosantosms rodrigosantosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this recommendation and query to / under Subscriptions , just like ServiceHealth.

@oZakari oZakari changed the title Update be448849-0d7d-49ba-9c94-9573ee533d5d.kql fix: Update be448849-0d7d-49ba-9c94-9573ee533d5d.kql Dec 16, 2024
oZakari
oZakari previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari added the Bug 🐞 Something isn't working label Dec 16, 2024
@oZakari oZakari requested a review from ejhenry December 16, 2024 22:07
@oZakari oZakari added the Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oZakari oZakari oZakari left review comments

@rodrigosantosms rodrigosantosms Awaiting requested review from rodrigosantosms

@ejhenry ejhenry Awaiting requested review from ejhenry

Assignees
No one assigned
Labels
Bug 🐞 Something isn't working Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Claudio-Merola @rodrigosantosms @oZakari